From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6931817C7DB; Tue, 9 Jul 2024 13:31:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720531900; cv=none; b=NfaCEztK65MyaJOzy2EIYemObm6DyLSi+TN8zv4rjp2hkpiei76jbr5ddR3ArYMks+K4YNFEsG+d72BWRKs+eQ5CH3n8UL3s8SA1vhruGVxY+urMN3jcbhbE6otZwKuFodcJ3u4L7d2q6sPtcCiCls3OkKc6RWCNkjG98VySqNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720531900; c=relaxed/simple; bh=4WP+WQ9nQvGm3F9qQzb3JcVtkEtMk1y8Lok9QkQkdaA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SqufbVOOumHFYxEHgZZ5oT7z8GV2mYlB3rIdiWcr+RkzF/ggvXJC7luBmUvLafZjOxxRwM5pJ7TbTXi+K7oYzOUZOEPGo3dQObRFMhNufe0H9ApOtnmbkOo7zafvEwv9kA3qFrlToYJABOAlDohjb/DZhtH8Jw4NV9Cz5fU1mtE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=2f+Eujxf; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="2f+Eujxf" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Zre5YSHteeLdEYtuTx/X+RGnWx775ASLQOdTxRDdE1M=; b=2f+Eujxf0jG9ADlgV4JEjThm70 ijEtLEUs5PC2z37RnVaF0M08Hvl0ZPDHZ7WYUK7azsyd9E/0uohZwhiEnMtmvjay5hIurMagJv5ZG BcvftJrTYNWO2BWi3y5juufyiUQ/mBqiSNv4FVLHqS/qv0gY5OurErVfDUE9+ixx5QjY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sRAwD-002945-K6; Tue, 09 Jul 2024 15:31:21 +0200 Date: Tue, 9 Jul 2024 15:31:21 +0200 From: Andrew Lunn To: Furong Xu <0x1207@gmail.com> Cc: "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net-next v1 7/7] net: stmmac: xgmac: enable Frame Preemption Interrupt by default Message-ID: <28ddf3e2-be4e-437a-b872-5ba07659e40e@lunn.ch> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jul 09, 2024 at 04:21:25PM +0800, Furong Xu wrote: > Frame Preemption Interrupt is required to finish FPE handshake. > > XGMAC_FPEIE is read-only reserved if FPE is not supported by HW. > There is no harm that we always set XGMAC_FPEIE bit. This is better, it explains what is going on, why the change is being made. But when i see this, i think about the interrupt handler. You don't just enable a new interrupt, you also need to handle the interrupt. Where is that handler code? The commit message is the place you try to answer the questions reviewers are going to ask. So if the interrupt handler already looks for this interrupt cause and handles it, add a statement to the commit message explaining it. Andrew