mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: meijusan <meijusan@163.com>, Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/ipv4/ip_fragment:fix missing Flags reserved bit set in iphdr
Date: Mon, 10 May 2021 21:05:54 -0600	[thread overview]
Message-ID: <28dfa69f-2844-29c4-5405-421520711196@gmail.com> (raw)
In-Reply-To: <1368d6c3.bd1.1795900a467.Coremail.meijusan@163.com>

On 5/10/21 7:18 PM, meijusan wrote:
> 
> At 2021-05-08 06:59:00, "Jakub Kicinski" <kuba@kernel.org> wrote:
>> On Thu,  6 May 2021 22:59:05 +0800 meijusan wrote:
>>> ip frag with the iphdr flags reserved bit set,via router,ip frag reasm or
>>> fragment,causing the reserved bit is reset to zero.
>>>
>>> Keep reserved bit set is not modified in ip frag  defrag or fragment.
>>>
>>> Signed-off-by: meijusan <meijusan@163.com>
>>
>> Could you please provide more background on why we'd want to do this?
> 
>> Preferably with references to relevant (non-April Fools' Day) RFCs.
> 
> [background]
> the Simple network usage scenarios: the one PC software<--->linux router(L3)/linux bridege(L2,bridge-nf-call-iptables)<--->the other PC software
> 1)the PC software send the ip packet with the iphdr flags reserved bit is set, when ip packet(not fragments ) via the one linux router/linux bridge,and the iphdr flags reserved bit is not modified;
> 2)but the ip fragments via router,the linux IP reassembly or fragmentation ,causing the reserved bit is reset to zero,Which leads to The other PC software depending on the reserved bit set  process the Packet failed.
> [rfc]
> RFC791
> Bit 0: reserved, must be zero
> RFC3514
> Introduction This bit , but The scene seems different from us,we expect Keep reserved bit set is not modified when forward the linux router
> 
> 
> 
> 
> 

Why process the packet at all? If a reserved bit must be 0 and it is
not, drop the packet.

  reply	other threads:[~2021-05-11  3:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 14:59 meijusan
2021-05-07 22:59 ` Jakub Kicinski
2021-05-11  1:18   ` meijusan
2021-05-11  3:05     ` David Ahern [this message]
2021-05-12  4:43       ` meijusan
  -- strict thread matches above, loose matches on Subject: below --
2021-05-05 13:25 meijusan
2021-05-05 17:39 ` kernel test robot
2021-05-05 17:59 ` kernel test robot
2021-05-06  9:37 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28dfa69f-2844-29c4-5405-421520711196@gmail.com \
    --to=dsahern@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=meijusan@163.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®