From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7993AC001B0 for ; Fri, 11 Aug 2023 08:52:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234543AbjHKIwO (ORCPT ); Fri, 11 Aug 2023 04:52:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229898AbjHKIwK (ORCPT ); Fri, 11 Aug 2023 04:52:10 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1846D2712; Fri, 11 Aug 2023 01:52:09 -0700 (PDT) Date: Fri, 11 Aug 2023 10:52:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1691743927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YBpK1gVUIGuSu6Q8X/sPY0RHI56c2CcVVsMSn3o9lA8=; b=YWmCxuqaPyFXZYtbg8XLRgNpfoYLNLJSKGUCKhFKvFLrGDHXLM26uabgv6jy09o5+6jy6V /XfjpmaKFXkr4697KMW704FdOvM7oBEqhFJHylsdmdbHnnYzKWydAFNUqz2SAO/lXbkfkm mdkDGIHnTraqPNIabhn1EdjR2jSMexVyg3wPbczML3trXbrRRr+9oSxOKLVy4pwvlpJ0m5 0b80LkbA39SwoIbKY30NemxDCVnPQIcmCXwQ1BuEJfTyWcKiN+1P2bLGKBlZrZiqueM6vt cblFnORjWeCqNXslsiEcxVbA/IIDQ47rq8O4Po0PXL2OAInFxo8j2+o/3+sNAg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1691743927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YBpK1gVUIGuSu6Q8X/sPY0RHI56c2CcVVsMSn3o9lA8=; b=pxCiC7Jt0Obuam3FqrqxN5tnlucxLXzuCNe3hwJsD/PbnJCni+ZThWUIpdjinNsBfH2OwF xF+xChq9KIe+ZbAQ== From: Anna-Maria Behnsen To: "Rafael J. Wysocki" cc: Linux PM , Peter Zijlstra , LKML , Frederic Weisbecker , Kajetan Puchalski Subject: Re: [RFT][PATCH v2 2/3] cpuidle: teo: Skip tick_nohz_get_sleep_length() call in some cases In-Reply-To: <2167194.irdbgypaU6@kreacher> Message-ID: <28e2d9ce-89db-807a-9d39-f2fcccfb2ad4@linutronix.de> References: <5712331.DvuYhMxLoT@kreacher> <2167194.irdbgypaU6@kreacher> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, On Thu, 3 Aug 2023, Rafael J. Wysocki wrote: > Index: linux-pm/drivers/cpuidle/governors/teo.c > =================================================================== > --- linux-pm.orig/drivers/cpuidle/governors/teo.c > +++ linux-pm/drivers/cpuidle/governors/teo.c > @@ -166,6 +166,12 @@ > */ > #define NR_RECENT 9 > > +/* > + * Idle state target residency threshold used for deciding whether or not to > + * check the time till the closest expected timer event. > + */ > +#define RESIDENCY_THRESHOLD_NS (15 * NSEC_PER_USEC) > + I would like to understand why this residency threshold is a fixed value and not related to TICK_NSEC. I'm sure there is a reason for it - but for me it is not obvious. Can you please explain it to me? Thanks, Anna-Maria