From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B425207A1A for ; Tue, 29 Oct 2024 21:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730235607; cv=none; b=bQByiERVsKBs7BWj5fp7DohncldFriiS+GXc4h76dqFv6SAI2mgMm3PEyOJelltieG7lTq6Nle14T3SBRd4VUtBAXz0Lvfeg2ru5y5ZP/z3fpYR+jU5szvyOpXfbLOtvmh/YOgjyi2ArnLZyWoe4TCFR9aQXYfnyOG5N9ZuvSYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730235607; c=relaxed/simple; bh=Ul/e2kCej6RPfHbTi51zGOAqEi3WrgU0ROTdX5hpnIo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KTCQhRL3hQOznpzECjTUJcOZzonoCJ46Cj7YfWBGl8mYxbiJZ0Eezqqyx/ARb551ICeNerXlpup+ghWXi72PsG+JE+GEXOLgx6rlzoGNlcNMP0wVxSe05SVu1abaK8o4rBgf16RSnzqjd5NaIcyW2y4MfyGRdx+NQh6tYdZJLYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=S/JEx9ys; arc=none smtp.client-ip=209.85.160.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="S/JEx9ys" Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-288c7567f5dso2856335fac.1 for ; Tue, 29 Oct 2024 14:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1730235605; x=1730840405; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sAxk75unEfa1XvvzuInBPAEOVG8E7pAoUhieZqfU6ug=; b=S/JEx9yswfstefjmqmL0RQsQuHUu/9qHcjftkiLB5CSQocQy46HHk0HJ0IOo0UgwqK ov6Abg1Pj+prXxQpDRw4Dbkk1JczNFjF67DTX1mjnw4w9MPi6pRVXF1gp6BioZ064NAS Vkzt2L3bUeNM0klmZC6bIgWrHzatdfkHqKrp1pQvR90d39otOhr149AodrbboizLAqVX dcTNPacNeDrWhqYJxb7/v6OlrOv+bVLc77vP6RDDGz7d4obHN4KNGqkAcN6bAq/Rrr48 2cn7lvMwn/nf8kgzOZ+/f7mNYVanaQcMWOg65tfHNNOWOD4ccKdo7ZRfwBEo3aVKFkU3 aJpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730235605; x=1730840405; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sAxk75unEfa1XvvzuInBPAEOVG8E7pAoUhieZqfU6ug=; b=FWIoYIbM9WBl/n27bklB5FmEgSKDf4mmxBWfWYF17CQi3KM64YA4AYW1I3tUtKNRZz gSc+CsjLyHmYsoY1abQbu8qC/Xn46OWEOYkxk4yG/B54pFBQKPjFFGXJIRXNR+xzNZyi ksxFjGzlg7TS8RD14puKy8DZyvOfihxnFpHtNAPMvGwtPK6yeUOWJT0PgqX2WJR/2fDo DgW6A1QWu6CC/DbAf4zsQXdU2dMsQmFkABUnSxpX+SNqJJFKzOPj2ThZesKECckF1oOe 6OryOjDJ8+bZEz/Kr5Q/T/oCp/nAPDu10E5sYGXmTv0I6B0bptRoJIvkxznbR/tjguZr BUog== X-Gm-Message-State: AOJu0YyyRgFixp56bCw0DAQGrETMrH2yJigaABYfguaLgw0vN7F43MqX ikqch4tIkSA7PYWTWIKK0qzMg0IB3KiTLX16UuAdirEg20520A4/v8CrkUdUQqGVw2MrPUVi+8G s X-Google-Smtp-Source: AGHT+IEMmkghZbZJEfvDYim8gZjbJlptfiFRHUPCAvIJTQjMKXcxCdAv5Xr3BiAZgSrsCCnMSMf9uQ== X-Received: by 2002:a05:6870:8321:b0:278:64e:c5ef with SMTP id 586e51a60fabf-29051d3bb23mr11805277fac.37.1730235604662; Tue, 29 Oct 2024 14:00:04 -0700 (PDT) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-718618a3747sm2301153a34.57.2024.10.29.14.00.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Oct 2024 14:00:04 -0700 (PDT) Message-ID: <28e6bf79-eac0-4ab2-8505-3d210cf145a9@baylibre.com> Date: Tue, 29 Oct 2024 16:00:03 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] dt-bindings: dma: adi,axi-dmac: deprecate adi,channels node To: "Rob Herring (Arm)" Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Krzysztof Kozlowski , Conor Dooley , Vinod Koul , devicetree@vger.kernel.org, Lars-Peter Clausen , Nuno Sa References: <20241029-axi-dma-dt-yaml-v2-0-52a6ec7df251@baylibre.com> <20241029-axi-dma-dt-yaml-v2-2-52a6ec7df251@baylibre.com> <173023455618.1620887.12454823992375368491.robh@kernel.org> Content-Language: en-US From: David Lechner In-Reply-To: <173023455618.1620887.12454823992375368491.robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/29/24 3:42 PM, Rob Herring (Arm) wrote: > > On Tue, 29 Oct 2024 14:29:15 -0500, David Lechner wrote: >> Deprecate the adi,channels node in the adi,axi-dmac binding. Prior to >> IP version 4.3.a, this information was required. Since then, there are >> memory-mapped registers that can be read to get the same information. >> >> Acked-by: Nuno Sa >> Signed-off-by: David Lechner >> --- >> >> For context, the adi,channels node has not been required in the Linux >> kernel since [1]. >> >> [1]: https://lore.kernel.org/all/20200825151950.57605-7-alexandru.ardelean@analog.com/ >> --- >> .../devicetree/bindings/dma/adi,axi-dmac.yaml | 19 +++++-------------- >> 1 file changed, 5 insertions(+), 14 deletions(-) >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/adi,axi-dmac.example.dtb: dma-controller@7c420000: 'adi,channels' is a required property > from schema $id: http://devicetree.org/schemas/dma/adi,axi-dmac.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241029-axi-dma-dt-yaml-v2-2-52a6ec7df251@baylibre.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > Ugh, somehow lost a line from v1 in the rebase and didn't notice. This is the part missing from this patch: @@ -109,7 +113,6 @@ required: - interrupts - clocks - "#dma-cells" - - adi,channels additionalProperties: false Will wait a bit for other feedback and then send a fixed version.