From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5B80213E89 for ; Fri, 1 Aug 2025 09:25:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754040330; cv=none; b=TWOnclIH1xObLaxZoTDEIiITSYuILaVQ5bJ3dsllIb7zJJ2LI2nlBpkrxiPCvGgvhDfTPstGci0DqjWdsEUJmbo5skNE8i1WklIzP6n379U5iLKn8YqKnUZ4ujlN3I8y5OhSEn396MkhGJerNnD74U9/XYnzESzK7metyFFf6aI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754040330; c=relaxed/simple; bh=SgjPPnF2nSUVlckPEUCh24utCeIdu2IsZFohqp3sj2c=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=B9QSLBKYcddTr/rkDIEm7g2P50LucE7lsJa23T21lo4h4SSPSpa1NptJsbQs+YjJQSsPwYyeqexsUzNo/4KWdASZc40/ZG9QpwZmIoUmS9o9b1RGlSb7x7HnIYQ6W63L7bUbfIi3Scrgz5tZKYdLesYhTnTuUskxZFiCXanjjXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4btgRr1wLfzPt6n; Fri, 1 Aug 2025 17:21:12 +0800 (CST) Received: from dggemv705-chm.china.huawei.com (unknown [10.3.19.32]) by mail.maildlp.com (Postfix) with ESMTPS id B336B1402EB; Fri, 1 Aug 2025 17:25:26 +0800 (CST) Received: from kwepemq100007.china.huawei.com (7.202.195.175) by dggemv705-chm.china.huawei.com (10.3.19.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 1 Aug 2025 17:25:19 +0800 Received: from [10.159.166.136] (10.159.166.136) by kwepemq100007.china.huawei.com (7.202.195.175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 1 Aug 2025 17:25:18 +0800 Message-ID: <28ebf640-ab2b-483c-8aed-d681f6c6ca5e@huawei.com> Date: Fri, 1 Aug 2025 17:25:18 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 drm-dp 10/11] drm/hisilicon/hibmc: adapting modification for the former commit To: Dmitry Baryshkov CC: , , , , , , , , , , , , , , , , , References: <20250718065125.2892404-1-shiyongbang@huawei.com> <20250718065125.2892404-11-shiyongbang@huawei.com> From: Yongbang Shi In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemq100007.china.huawei.com (7.202.195.175) > On Fri, Jul 18, 2025 at 02:51:24PM +0800, Yongbang Shi wrote: >> From: Baihan Li >> >> Add colorbar disable operation before reset chontroller, to make sure >> colorbar status is clear in the DP init, so if rmmod the driver and the >> previous colorbar configuration will not affect the next time insmod the >> driver. > In this one and in the next one please fix commit subjects. Can't parse > them. Sorry about that, I will fix them! >> Fixes: 3c7623fb5bb6 ("drm/hisilicon/hibmc: Enable this hot plug detect of irq feature") >> Signed-off-by: Baihan Li >> Signed-off-by: Yongbang Shi >> --- >> ChangeLog: >> v2 -> v3: >> - fix the issue commit ID, suggested by Dmitry Baryshkov. >> - split into 2 commits, suggested by Dmitry Baryshkov. >> - add more comments in commit log, suggested by Dmitry Baryshkov. >> --- >> drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c b/drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c >> index 36daf7542d40..85499f1ace8b 100644 >> --- a/drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c >> +++ b/drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c >> @@ -180,6 +180,8 @@ int hibmc_dp_hw_init(struct hibmc_dp *dp) >> /* int init */ >> writel(0, dp_dev->base + HIBMC_DP_INTR_ENABLE); >> writel(HIBMC_DP_INT_RST, dp_dev->base + HIBMC_DP_INTR_ORIGINAL_STATUS); >> + /* clr colorbar */ >> + writel(0, dp_dev->base + HIBMC_DP_COLOR_BAR_CTRL); >> /* rst */ >> writel(0, dp_dev->base + HIBMC_DP_DPTX_RST_CTRL); >> usleep_range(30, 50); >> -- >> 2.33.0 >>