From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 975F2311C1B for ; Tue, 18 Nov 2025 09:33:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763458422; cv=none; b=Cc3vOenXe3pom4cLoxXR4uS5Cl98K3jSPXGT+ILBM9fE7rFhUIPWY4PXPFO9nxyvU3v+1gmWmj+yd6ukiDvafWpdE45GEYKWlCT/ztvzH0l9qjZP8SjbF4fhP8tjqlW6TVBASmotR7Z+2VpNqV3DN7uby4tmCapwVyYM2T3mO8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763458422; c=relaxed/simple; bh=+50Ey2th+tvNWLHYjF3fekOQvXPxWkgWTW4J+kjkuuI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DHGUJl2mFWIcpdbsLTCOzgwdQHzm2EYqxDpl1JxCtFgqy3gngJ/ofoYphSHLEcQkgQFGcqbg76F6Sfn/dUkdxjPn6hIW+Mst3nJIGxqtKwDwimdoxLSi4+gojNop68GfyeX1xAOKVPFugNhakvMRbAFW3Ah50Z92B61MxTkXd/A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Y+2GtTlk; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y+2GtTlk" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-477aa218f20so3202815e9.0 for ; Tue, 18 Nov 2025 01:33:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763458419; x=1764063219; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lTOCRDtXGRsyXp0u8jNTz0TfJTFFmawtdeFt+8GZM68=; b=Y+2GtTlkNQxatit+63DAyzp440oXvf+KzxiB5+dz9/PGKW5mAQa6emkJG4aBVaL4na NtHlFYbXEl3qsbfF59W7vq8Ls++edU5LajSij7+f7MB/c+X2bdJJ+8Kj4rOVihpYaxWx BsM9vOWPBcsaJ+Xo44z2msIr/jk5DjkAEWsbwte4CxeBKGvdxme2MjCK8qPo7N3zZXFY hznAhrA98Q9NdvZh/0pV1tjrlDgukY4boCOdn6kkw5WspKYpSGv9F/Yc5Xt4i4H8L3fl N9VMro/eyoXpDHHKJZHtZBHOvhVG9KDzknz6FggTTob3S3RKtcQ4s/oi6nk8ztMjRE/H 7d2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763458419; x=1764063219; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lTOCRDtXGRsyXp0u8jNTz0TfJTFFmawtdeFt+8GZM68=; b=oXRSvr8mTYLBjkGgX4D0em7oTrYGZEUbSifH0ttWSEJoxev4QCF3D/y/jpAZN2RqPq YAs62+6ImulbWRt8SriS1Cc6c39M/PlqEPwmsYEdAr1b5Fsw0+ZjrRMm225xGPKdy+j/ h8TOhgmn9HjRlHJVvXgUkq5tFi96NucnSbrX5CNxcQWrbXHSeNd6YT3+gc0tbbzq5clM kLJ3U2k7sNBj+KN3z19t5+xcojeDZEAHVQ/Da55hZT66COrU6GCXWoXGDGpDLb4ucRUK 6Ore1eAF1DfqSnmEGcQJlbhyJq0K6x6EIUUA1ciLKORV2J8AL0if2ArwYMNmktTolaN/ 0E1g== X-Forwarded-Encrypted: i=1; AJvYcCX0PQxNP/FqhSQtVCAc71WKVc89A3ApYU4HO6Y175jn4J1L1TcvSqBVGCYrVE5fNbFjB3ZYHHWyaW52/a4=@vger.kernel.org X-Gm-Message-State: AOJu0YzTic9Byxu3i6zQp2jStaX2DpXGAGVW7ZgsMtkmCSI0GDMzcd7o foysna3iMsdvha2vc+tR/nJtOMN9Wi3DiudNSBKPau75WyK9rEj4U91W/UKcijPbs4o= X-Gm-Gg: ASbGncsvfjIBxrttntgYBplg1GyOL03vzxjWo/7btKzqlrY9kcbYZDF4ximCJ4isvgA KdBfKhVrTDw3+NqEjDTGJXonc/I5nOfdvbfYNeKQkxJew8anijnrewjumzsz7D7W3hbPjOnYRrO sfh31fL31OipknnGUTEU284/q3iYC5t0LMlgdH3K8hzfIZ8PCenZNQfRyE2+m7MPghfoByZDEZP kzbURPghtc/ErQd+HVbA4zb6AZSz6yV98nY1m/XFBqsUiDXRJK69/9y+ex+yiFTN+umUUhSNTEq VgflThzSXCavzZKgaUyn5CfN6qh4rleYQuH56EkhOwXrsVLARpoa/ECRz2w3V6U9WN6zrRJ1u9s ALKvu1iI4wGF3DoBttZYEKqgeH1iF7xXg2HkVxQOOwJnXK44Qk/bfUks+GAScMmti1LJEtK6YVQ bI9MmuOVEB8eQ958ogFAf6EjfgSzQ+kGL7HQ8ohTJeA4a/Y5gkvnJLJnCa/+eJCJuVhcWT6RjlR Q== X-Google-Smtp-Source: AGHT+IGjvYXGcM8w+Yy+Mw51ltxXu22tj1ZNHWr9tLZbYKT9LQg2FaVpLbb1z4I+LQJU8q7Yzr3yiA== X-Received: by 2002:a05:600c:1caa:b0:477:76cb:4812 with SMTP id 5b1f17b1804b1-4778fe0694amr165159625e9.0.1763458418772; Tue, 18 Nov 2025 01:33:38 -0800 (PST) Received: from [192.168.0.27] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477a9df99d3sm11797575e9.12.2025.11.18.01.33.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 01:33:38 -0800 (PST) Message-ID: <28f33d3a-6866-4bdb-a1e5-d193dcb7d4d1@linaro.org> Date: Tue, 18 Nov 2025 09:33:35 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/3] Add CAMSS support for SM6350 To: Konrad Dybcio , Luca Weiss , Bryan O'Donoghue , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <3ph8XeidoxkUIsK7qiOH29pde94sdwa3ReWKVVrPabgS5enIAmwVAC5plyFnBMJGKQBnxFB6df6j69OMFIeavw==@protonmail.internalid> <20251114-sm6350-camss-v2-0-d1ff67da33b6@fairphone.com> <17e7ebc9-3b88-4334-b87d-1bce6d5bb120@linaro.org> <893b97ad-7d2b-4408-bab5-2cd63fdaa33b@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <893b97ad-7d2b-4408-bab5-2cd63fdaa33b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 17/11/2025 12:53, Konrad Dybcio wrote: > On 11/16/25 3:30 PM, Bryan O'Donoghue wrote: >> On 14/11/2025 15:59, Luca Weiss wrote: >>> On Fri Nov 14, 2025 at 4:51 PM CET, Bryan O'Donoghue wrote: >>>> On 14/11/2025 11:15, Luca Weiss wrote: >>>>> Add bindings, driver and dts to support the Camera Subsystem on the >>>>> SM6350 SoC. >>>>> >>>>> These patches were tested on a Fairphone 4 smartphone with WIP sensor >>>>> drivers (Sony IMX576 and IMX582), the camera pipeline works properly as >>>>> far as I can tell. >>>>> >>>>> Though when stopping the camera stream, the following clock warning >>>>> appears in dmesg. But it does not interfere with any functionality, >>>>> starting and stopping the stream works and debugcc is showing 426.4 MHz >>>>> while the clock is on, and 'off' while it's off. >>>>> >>>>> Any suggestion how to fix this, is appreciated. >>>>> >>>>> [ 5738.590980] ------------[ cut here ]------------ >>>>> [ 5738.591009] gcc_camera_axi_clk status stuck at 'on' >>>>> [ 5738.591049] WARNING: CPU: 0 PID: 6918 at drivers/clk/qcom/clk-branch.c:87 clk_branch_toggle+0x170/0x190 >>>> >>>> Do you have a full and complete kernel tree we could look at here ? >>> >>> Sure, this branch has everything in: >>> >>> https://github.com/sm6350-mainline/linux/tree/sm6350-6.17.y/ >>> >>> For further refence, at least two other people have tested this branch >>> in postmarketOS, nothing particularly exciting to report from there, >>> apart from that the sdm-skin-thermal thermal zone (thermistor right next >>> to SoC) is currently configured with 55 degC as critical trip, which is >>> quickly achieved when starting a video recording, but that's not really >>> an issue with camss, but will need some tweaking regardless. >>> >>> https://gitlab.postmarketos.org/postmarketOS/pmaports/-/merge_requests/7281 >> >> diff --git a/drivers/clk/qcom/gcc-sm6350.c b/drivers/clk/qcom/gcc-sm6350.c >> index a4d6dff9d0f7f..229629ef82809 100644 >> --- a/drivers/clk/qcom/gcc-sm6350.c >> +++ b/drivers/clk/qcom/gcc-sm6350.c >> @@ -908,9 +908,7 @@ static struct clk_branch gcc_camera_ahb_clk = { >> >>  static struct clk_branch gcc_camera_axi_clk = { >>         .halt_reg = 0x17018, >> -       .halt_check = BRANCH_HALT, >> -       .hwcg_reg = 0x17018, >> -       .hwcg_bit = 1, > > No reason to drop the hwcg description > >> +       .halt_check = BRANCH_VOTED, > > It'd be useful to explain why we should ignore the hw feedback in this case > >>         .clkr = { >>                 .enable_reg = 0x17018, >>                 .enable_mask = BIT(0), > > Konrad vfe170 is what we have on sdm845 So I'm just asking Luca to try the sdm845 method of waggling this clock since what we have doesn't work. --- bod