From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752270AbdBRAQB (ORCPT ); Fri, 17 Feb 2017 19:16:01 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33343 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751994AbdBRAQA (ORCPT ); Fri, 17 Feb 2017 19:16:00 -0500 Subject: Re: [Suggestion/Problems] perf annoate: Some problems related to the source code view and Improvement of it with line numbers To: Arnaldo Carvalho de Melo References: <5c703d64-3ef4-3d43-bf99-f14c5fc4cdac@gmail.com> <20170215132411.GF4020@kernel.org> <963c309b-ca3a-e5a7-30f3-e0a521e5c3e5@gmail.com> <20170217132939.GA4109@kernel.org> Cc: Jiri Olsa , Namhyung Kim , perf group , LKML , Ingo Molnar , Peter Zijlstra From: Taeung Song Message-ID: <28f6e48a-9c4e-82e8-d48a-6b5f7aaae768@gmail.com> Date: Sat, 18 Feb 2017 09:15:49 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20170217132939.GA4109@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/17/2017 10:29 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Feb 17, 2017 at 11:33:29AM +0900, Taeung Song escreveu: >> Hi, Arnaldo :) >> >> Regarding perf annotate: >> >> 1) Problem : wrong line numbers on perf-annotate (both stdio and TUI) >> 2) Problem : wrong sum of overhead(percent) matching source lines >> 3) Suggestion : new option showing only source code per function >> with overhead info (to be more readable :) ) >> >> I'll send the patchset for them, maybe it'll a bit take time. >> But I won't be long.. > > Concentrate on the first, send the patch, while waiting for review, work > on the second, and so on :-) > > - Arnaldo > Understood! I appreciate your concern :) Thanks, Taeung