Re: [PATCH net 0/2] selftests: mptcp: connect: cover alt modes

[Matthieu Baerts <matttbe@kernel.org>]

Hello,

On 14/07/2025 17:52, Matthieu Baerts (NGI0) wrote:
> mptcp_connect.sh can be executed manually with "-m <MODE>" and "-C" to
> make sure everything works as expected when using "mmap" and "sendfile"
> modes instead of "poll", and with the MPTCP checksum support.
> 
> These modes should be validated, but they are not when the selftests are
> executed via the kselftest helpers. It means that most CIs validating
> these selftests, like NIPA for the net development trees and LKFT for
> the stable ones, are not covering these modes.
> 
> To fix that, new test programs have been added, simply calling
> mptcp_connect.sh with the right parameters.

I just noticed these new tests print nested TAP output containing
subtest results with the same content as the mptcp_connect.sh test. In
other words, NIPA or other CIs will think the exact same tests are now
executed 4 times, e.g.

  # ok 2 - mptcp_connect: ping tests # time=2887ms

I will force new tests' prefixes to have different test names.

pw-bot: cr

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.