From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965708AbdIYTP6 (ORCPT ); Mon, 25 Sep 2017 15:15:58 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:34681 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934555AbdIYTPy (ORCPT ); Mon, 25 Sep 2017 15:15:54 -0400 X-Google-Smtp-Source: AOwi7QAS8Woy3TTYDdcjw5/RL5u2hoIq5FavyrGCcmLfj3NSnYzimqNsh0lCM7e9t7I2UN+5SwSTZg== Subject: Re: [PATCH 2/2] pinctrl: single: Allow indicating loss of pin states during low-power To: Linus Walleij , Florian Fainelli , ext Tony Lindgren Cc: "linux-kernel@vger.kernel.org" , Stephen Warren , Andy Shevchenko , Al Cooper , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , Rob Herring , Mark Rutland , bcm-kernel-feedback-list References: <20170921010421.7467-1-f.fainelli@gmail.com> <20170921010421.7467-3-f.fainelli@gmail.com> From: Florian Fainelli Message-ID: <2905a73d-2e73-e590-12a2-f7af7ac83b9e@gmail.com> Date: Mon, 25 Sep 2017 12:15:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/22/2017 06:03 AM, Linus Walleij wrote: > On Thu, Sep 21, 2017 at 3:04 AM, Florian Fainelli wrote: > >> Some platforms (e.g: Broadcom STB: BMIPS_GENERIC/ARCH_BRCMSTB) will lose >> their register contents when entering their lower power state. In such a >> case, the pinctrl-single driver that is used will not be able to restore >> the power states without telling the core about it and having >> pinctrl_select_state() check for that. >> >> This patch adds a new optional boolean property that Device Tree can >> define in order to obtain exactly that and having the core pinctrl code >> take that into account. >> >> Signed-off-by: Florian Fainelli > > If we use this per-controller approach rather than the per-state approach > I discuss in reply to patch 1/2, we should probably make it a generic > property for pin controllers and not just a pinctrl-single business. I suppose it makes sense to make this a generic pinctrl property then. drivers/pinctrl/core.c does not appear to be trying to fetch any properties for a pinctrl device, but that is probably not too hard to add. > > So patch pinctrl-bindings.txt and put the code somewhere in > core. > > But that is more of a detail, first we need to figure out how to > handle this business in general. Fair enough. -- Florian