From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756683AbcAZLuY (ORCPT ); Tue, 26 Jan 2016 06:50:24 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:55945 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756014AbcAZLuV (ORCPT ); Tue, 26 Jan 2016 06:50:21 -0500 From: Arnd Bergmann To: Herbert Xu Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, "David S. Miller" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] crypto: jitterentropy - always select CRYPTO_RNG Date: Tue, 26 Jan 2016 12:49:36 +0100 Message-ID: <29082633.aRvKnNisWH@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160126103018.GA19508@gondor.apana.org.au> References: <1453740644-1980309-1-git-send-email-arnd@arndb.de> <20160126103018.GA19508@gondor.apana.org.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:BAUV+KmaWx3aN+igj90RWeh1f7hMIuxZfkEAAMWueQaMP0IKPdw 41IBQJfLctW+07s1oRPq0rjSOh99gz+aYaBmpvYc/lTfFQbwp2IX+qN0vXRk2mDpeXvl0LW Sv9dVo9M6JXH/65Ad7jJuVvgFt5c/4ErlfRMiaIOFslO+/AxfKNZODHy3PIFsUYahDsTKEI s644M5byvg3Z2HH3x9nLg== X-UI-Out-Filterresults: notjunk:1;V01:K0:t2UpBQv/3I4=:W4P78gg88qGdQM9D9aBSiY 5gmWT7htQUFnKtj9lvXBQRrFo/I6LaoaA8eYZF1en5nAgeEnfln8uNGH+yHcZR/AUTCNH0REK ds0yBXSurwJ2i9WiWMXCdCCqZbrAegzeMcb3D01ibQ1z6sqnQxZwxZj5V0Djo4+3iDHRkdmBi fonXqG+E71h1NurhfUl6UOfofu0vyEDmGtf+3+adJ9xpn9fWhaSKoQlrkTWqDYB8FfSkI4mVw burscqnDEvvrd9nKVC9uM9y9+JeEEBP819bqTWM7XEmDamyk9ZFHftRukND6sUNmctJYrGo+x SpGvtW+j/5S6MaFL9IaeqWQFF3rt5lFLpRTFXX1DnldUCCtH8BEGgGDjQZUOKNkImwLpUVFMb 9IPU/YNs9960NId+FgT2UC1FKKIJR/Ax9lGe8byOj1cpz0ZRLZlmzQrZfoRItDMzQOx0cu7LB +SASRVFyEEgnH5xy3DZAAvBJGs+n/PQdCAixioh7+r5hfYJPMFpfwAaujED5bf4HQzIjUUguk 4ZPxFvuIbCvGPROyuT2zGJbaAbmjI7RxkQJ4soy0LGg8/OJ7Z2Xi8pb5Tn03QKZcV6IikmnA5 gauixB993TdlX536NTZO4PYGwrJHE3ZsAnGyxi/BGPKQFuH+czczw1LdsKNqTN6nGl0J6T0RW MtlwMWtnG0EG7Pek++Yo4CvG1MTpsoiwfUVbzyDXBwetvrW7JPQTXHunbtttMBpwU/8vY06WF jibNvw8VUJm1hiFA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 26 January 2016 18:30:18 Herbert Xu wrote: > On Mon, Jan 25, 2016 at 05:50:34PM +0100, Arnd Bergmann wrote: > > When building the jitterentropy driver by itself, we get a link error > > when CRYPTO_RNG is not enabled as well: > > > > crypto/built-in.o: In function `jent_mod_init': > > jitterentropy-kcapi.c:(.init.text+0x98): undefined reference to `crypto_register_rng' > > crypto/built-in.o: In function `jent_mod_exit': > > jitterentropy-kcapi.c:(.exit.text+0x60): undefined reference to `crypto_unregister_rng' > > > > This moves the 'select CRYPTO_RNG' from CRYPTO_DRBG to CRYPTO_JITTERENTROPY > > to ensure the API is always there when it's used, not just when DRBG is > > also enabled. > > > > Signed-off-by: Arnd Bergmann > > --- > > crypto/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/crypto/Kconfig b/crypto/Kconfig > > index 7240821137fd..99109b93604a 100644 > > --- a/crypto/Kconfig > > +++ b/crypto/Kconfig > > @@ -1586,13 +1586,13 @@ config CRYPTO_DRBG_CTR > > config CRYPTO_DRBG > > tristate > > default CRYPTO_DRBG_MENU > > - select CRYPTO_RNG > > I think we should leave this there as DRBG itself is an RNG and > it just uses JITTERENTROPY which happens to be an RNG. Good idea. Should I resend a modified version or do you want to just adapt it yourself? Arnd