From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752595AbcGAJoX (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 Jul 2016 05:44:23 -0400
Received: from mout.kundenserver.de ([217.72.192.75]:59242 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752113AbcGAJoT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 Jul 2016 05:44:19 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Jon Mason <jon.mason@broadcom.com>
Cc: zajec5@gmail.com, davem@davemloft.net, f.fainelli@gmail.com,
        hauke@hauke-m.de, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac
Date: Fri, 01 Jul 2016 11:46:04 +0200
Message-ID: <29091648.CIZSyGWL7u@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1467327554-22074-7-git-send-email-jon.mason@broadcom.com>
References: <1467327554-22074-1-git-send-email-jon.mason@broadcom.com> <1467327554-22074-7-git-send-email-jon.mason@broadcom.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:pGZ1OJRVl2TkXej9j0Us8lMLwrcDQu1FuJCN+YObgfHR8TeEfGy
 E/ooAKeJL8e4B5a9gpwsnwNaFWyD5JPOnr760a3tBVqdj8jRMO4bvBDzlZhQ+LzOOqdqGqW
 zfzzxsDCaYYBTfzJiySpgrFUGTT9I0Usi2Egf79klkkWXebsQFb2gAbSzAfvfxA9i39jQLZ
 AFvFFV9h5QgSFddyccPqg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:ojBUaBLZHck=:/yXd+FzDyLEEQNlcEY50Ow
 K5nvPuVqgMxhkYezzRBuR1b9jJwAq7flOKrAB/jckWpu9Rmac//dM+bFXBAbWGTx98x9YgAt+
 4ExEaSYMKfv2Y+zmfPt+bytdcSO9NZZXVg5zjICzv7RNSlPbyaiV5PaLIT+Isyo3kHN1DY54Y
 +I4b1iz65lHDbooGw5uBMxmeicpg+MjHoYviZab/AM0yY8/YPBGw4TUnXJh1B581F9YqsQmWs
 +sB11xd2m4ongtvkgbFmXFS+aI4g2UNc8BiibTfih/UKZBgpbHkJyxTwHNJRMnl4f9Uh13t54
 jQDXGbbSu6KKuRX/y1UnWk7edZYRHSfUfIBqvVrT2bI8Ceh8Hya1aTFo8jIyaXLpMvJMW+6Gz
 glhxRXQy/nnL3xPumm391KYoayjYPaMq0RPB59u2B+lD2Xh9JEJTzxkNyWhipJJ4uP2XyVfBu
 e71Ide5TEP5/9CIGVBxaNMAEUZtGdoSm4TMxPxfNr+6PY28UtPMd5KxK0hz7TzywzYSvBD2Yg
 DiruLNbvmeYkTy07Z+vQkGkWcFpdRuFslBm83TNFWsJf/h/N7tr+HF8lyN07krLAqz3/d5ZRR
 QvPHiH0KHYpt3d9I2iwvfZZWSyL2IwBJjxDkthZngAbRsSWj9f7VcymFjqLzp+/ZzFuz9c4ps
 YnNSHXUFA5gNMekFS/RChfCI/W9bTOSIf3ME2xTMNy9h4bS1q6PyLNZaMf1fvPUKZXt8UgmjU
 aVN+N+/SpXEDWEEA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, June 30, 2016 6:59:13 PM CEST Jon Mason wrote:
> +
> +Required properties:
> + - compatible: "brcm,bgmac-nsp"
> + - reg:                Address and length of the GMAC registers,
> +               Address and length of the GMAC IDM registers
> + - reg-names:  Names of the registers.  Must have both "gmac_base" and
> +               "idm_base"
> + - interrupts: Interrupt number
> +


"brcm,bgmac-nsp" sounds a bit too general. As I understand, this is a family
of SoCs that might not all have the exact same implementation of this
ethernet device, as we can see from the long lookup table in bgmac_probe().

Please document the specific product numbers here that are publically
known already. Having the driver match just on "brcm,bgmac-nsp" as a fallback
is fine, so you can document that one as required for all users.

	Arnd