From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751263AbdGMEIo (ORCPT ); Thu, 13 Jul 2017 00:08:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:57344 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751067AbdGMEIm (ORCPT ); Thu, 13 Jul 2017 00:08:42 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BA6722BD9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=chao@kernel.org Subject: Re: [f2fs-dev] [PATCH v2] f2fs: Don't clear SGID when inheriting ACLs To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jan Kara , stable@vger.kernel.org References: <20170711205324.90260-1-jaegeuk@kernel.org> <20170711233124.GA96177@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: <290aabd7-dc61-081a-bbda-74fa97197e62@kernel.org> Date: Thu, 13 Jul 2017 12:08:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170711233124.GA96177@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/7/12 7:31, Jaegeuk Kim wrote: > This patch copies commit b7f8a09f80: > "btrfs: Don't clear SGID when inheriting ACLs" written by Jan. > > Fixes: 073931017b49d9458aa351605b43a7e34598caef > CC: stable@vger.kernel.org > Signed-off-by: Jan Kara > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, > --- > > Change log from v1: > - fix for simple change > > fs/f2fs/acl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c > index a140c5e3dc54..b4b8438c42ef 100644 > --- a/fs/f2fs/acl.c > +++ b/fs/f2fs/acl.c > @@ -211,7 +211,7 @@ static int __f2fs_set_acl(struct inode *inode, int type, > switch (type) { > case ACL_TYPE_ACCESS: > name_index = F2FS_XATTR_INDEX_POSIX_ACL_ACCESS; > - if (acl) { > + if (acl && !ipage) { > error = posix_acl_update_mode(inode, &inode->i_mode, &acl); > if (error) > return error; >