From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752155AbdEIHIX (ORCPT ); Tue, 9 May 2017 03:08:23 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:49957 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752006AbdEIHIV (ORCPT ); Tue, 9 May 2017 03:08:21 -0400 Subject: Re: [PATCH] qca_debug: Reduce function calls for sequence output in qcaspi_info_show() To: SF Markus Elfring , netdev@vger.kernel.org, "David S. Miller" , Philippe Reynes References: <9932ee63-f766-49ce-d760-9a0bd06f0657@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: Stefan Wahren Message-ID: <290d2473-73bd-70db-b6ef-c50331812f31@i2se.com> Date: Tue, 9 May 2017 09:07:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <9932ee63-f766-49ce-d760-9a0bd06f0657@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:vpprFN2T3PDHUsNfBPNi/ru1yDT6Bckq6pbp/A9HgnYFnZDwnVC +4eO1clyUAHduxAt6RvnY4BMseCGX7FLbZTXDR0LS/bvkyDSUd/dceuIwvqvnuxF5IzrMOg qMh50Je+8njjiupMVqltkNCV2QA9PPt7AYseO66j/3piAEXZxykDUTyk6yVIX/Zt2nS6AKZ st1cJQaK9QzjCWHA5HDrw== X-UI-Out-Filterresults: notjunk:1;V01:K0:VGuhCeziE4g=:aJF5rI8njDiKo8UZyoTei2 JHzYOr76jDmG28nHpolbkViRMiRy+F5J1ClmjUoLQIcmJrHZ82MKdFYY+SYdO2jZ1I2VGBLQ+ o4y14dqHmQv1hW64p6YYP1B5tnlQKwU4oF63sssx3LvMGZDMC3iclucL/099H+QYJr9/5UT/f rhr9dPenQ0MpnJglaxCIjVPib3lWd6E8/8cGrzgeCIYjsHd6MqTidqudrAfnf8shqzSjce8Bl vGQGubv9d+mrzPgd9D1/wgvW7khyMOwYS7v+ZJ6gxNQX8SGPm/2vkPxfhPqLANpos6CUL3XV5 KKRUPlNIOo+VV5FxWYPI9B4ZQfJzZrQb5ghH6RbE1Bcc9iJdb++dwjcRUqVYjy0hzBOUU51rE E15eEfusZimT2j6QiOdeGPjxrQR5kNWXFzEKS6VALCU8Jx0GaPABCEjAmlcILusAuJZfVJsxB XNvOm9rpGJ6xohrBgTrkotAiYXBwAK4LxJnQ5XfG34WQxe93fc4nZjKG3SeD8JuyLRvqkNbsQ pbtdyu60FyWT8mVnFmjPqdS9Fzzb+6TNt+vXhsIx9FWg8Pw2sok1Plx16gq5tIHca2r/VbDmh YN4472JpQ+bPj1dBIb5ub+U3R8CnCj8wkr7nA1oTvJ3mbDF0EjAR7KGSgZtVw19bhtpK50CGU is3kS4eqJ313aulb2CbPLpl3jhuQTBL/fzTl+WKwL2Fs+/IYKsj1sFNjkqVRNCA/bTessPGCR 5Ac3AvhUChR4+RlZ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 08.05.2017 um 19:29 schrieb SF Markus Elfring: > From: Markus Elfring > Date: Mon, 8 May 2017 19:21:27 +0200 > > A bit of data was put into a sequence by separate function calls. > Print the same data together with adjusted seq_printf() calls instead. Sorry, i'm not happy with this patch. It doesn't increase readabilityand mixes the output of multiple lines. The only benefit is a little bit higher performance. But for debugfs this won't be necessary. Stefan > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/net/ethernet/qualcomm/qca_debug.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) >