From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2465FC83F2D for ; Sun, 3 Sep 2023 05:59:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235911AbjICF7g (ORCPT ); Sun, 3 Sep 2023 01:59:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229586AbjICF7e (ORCPT ); Sun, 3 Sep 2023 01:59:34 -0400 X-Greylist: delayed 323 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sat, 02 Sep 2023 22:59:31 PDT Received: from mp-relay-01.fibernetics.ca (mp-relay-01.fibernetics.ca [208.85.217.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7AEC1A8; Sat, 2 Sep 2023 22:59:31 -0700 (PDT) Received: from mailpool-fe-01.fibernetics.ca (mailpool-fe-01.fibernetics.ca [208.85.217.144]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mp-relay-01.fibernetics.ca (Postfix) with ESMTPS id 9A95AE17C2; Sun, 3 Sep 2023 05:54:07 +0000 (UTC) Received: from localhost (mailpool-mx-01.fibernetics.ca [208.85.217.140]) by mailpool-fe-01.fibernetics.ca (Postfix) with ESMTP id 8A46F42959; Sun, 3 Sep 2023 05:54:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at Received: from mailpool-fe-01.fibernetics.ca ([208.85.217.144]) by localhost (mail-mx-01.fibernetics.ca [208.85.217.140]) (amavisd-new, port 10024) with ESMTP id djPA813dL2lx; Sun, 3 Sep 2023 05:54:07 +0000 (UTC) Received: from [192.168.48.17] (host-104-157-209-188.dyn.295.ca [104.157.209.188]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dgilbert@interlog.com) by mail.ca.inter.net (Postfix) with ESMTPSA id 7702D4295D; Sun, 3 Sep 2023 05:54:06 +0000 (UTC) Message-ID: <290ebce4-54f0-8ac1-2a13-cbc806d80d64@interlog.com> Date: Sun, 3 Sep 2023 01:54:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Reply-To: dgilbert@interlog.com Subject: Re: [PATCH v4] hwmon: add POWER-Z driver Content-Language: en-CA To: Guenter Roeck , =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= , Christophe JAILLET Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20230902-powerz-v4-1-7ec2c1440687@weissschuh.net> <36a3daf7-d519-7669-13bf-4c59c11c2b97@wanadoo.fr> <46d3194a-af79-4076-b0a2-561d713a406e@t-8ch.de> <2776f856-94e4-1481-508a-db80db573be0@roeck-us.net> From: Douglas Gilbert In-Reply-To: <2776f856-94e4-1481-508a-db80db573be0@roeck-us.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-09-02 18:56, Guenter Roeck wrote: > On 9/2/23 15:29, Thomas Weißschuh wrote: >> Hi, >> >> On 2023-09-02 18:36:17+0200, Christophe JAILLET wrote: >>> Le 02/09/2023 à 09:47, Thomas Weißschuh a écrit : >>>> POWER-Z is a series of devices to monitor power characteristics of >>>> USB-C connections and display those on a on-device display. >>>> Some of the devices, notably KM002C and KM003C, contain an additional >>>> port which exposes the measurements via USB. >>>> >>>> This is a driver for this monitor port. >>>> >>>> It was developed and tested with the KM003C. >>>> >>>> Signed-off-by: Thomas Weißschuh >>>> --- >>> >>> ... >>> >>>> +static int powerz_probe(struct usb_interface *intf, >>>> +            const struct usb_device_id *id) >>>> +{ >>>> +    struct powerz_priv *priv; >>>> +    struct device *hwmon_dev; >>>> +    struct device *parent; >>>> + >>>> +    parent = &intf->dev; >>>> + >>>> +    priv = devm_kzalloc(parent, sizeof(*priv), GFP_KERNEL); >>>> +    if (!priv) >>>> +        return -ENOMEM; >>>> + >>>> +    priv->urb = usb_alloc_urb(0, GFP_KERNEL); >>>> +    if (!priv->urb) >>>> +        return -ENOMEM; >>>> +    mutex_init(&priv->mutex); >>>> +    priv->status = -ETIMEDOUT; >>>> +    init_completion(&priv->completion); >>>> + >>>> +    hwmon_dev = >>>> +        devm_hwmon_device_register_with_info(parent, DRIVER_NAME, priv, >>>> +                         &powerz_chip_info, NULL); >>>> +    usb_set_intfdata(intf, priv); >>>> + >>>> +    return PTR_ERR_OR_ZERO(hwmon_dev); >>> >>> Hi, >>> >>> If 'hwmon_dev' is an PTR_ERR, priv->urb leaks. >> >> Good catch, thanks! >> >> >> Guenter, >> >> it seems the new hwmon-next with this driver has not yet been pushed to >> git.kernel.org, so I can't generate the Fixes tag. >> > > Rule is that I must not push anything into linux-next until > after v6.6-rc1 has been released. > >> Can you modify the commit to also contain the changes below? >> Or let me know if you prefer something else. >> > > I'll update the patch and make the change. Hi, While you are at it, you can make the driver detect the earlier model KM002C: --- powerz.c_orig 2023-09-02 13:47:14.754705791 -0400 +++ powerz.c 2023-09-02 23:22:54.783856587 -0400 @@ -250,6 +250,7 @@ static const struct usb_device_id powerz_id_table[] = { { USB_DEVICE_INTERFACE_NUMBER(0x5FC9, 0x0063, 0x00) }, /* ChargerLAB POWER-Z KM003C */ + { USB_DEVICE_INTERFACE_NUMBER(0x5FC9, 0x0061, 0x00) }, /* ChargerLAB POWER-Z KM002C */ { } }; Do you want a "Tested-by" on the patch as well? Doug Gilbert