From: Yang Jihong <yangjihong1@huawei.com>
To: Ian Rogers <irogers@google.com>, Adrian Hunter <adrian.hunter@intel.com>
Cc: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
<jolsa@kernel.org>, <namhyung@kernel.org>,
<kan.liang@linux.intel.com>, <james.clark@arm.com>,
<tmricht@linux.ibm.com>, <ak@linux.intel.com>,
<anshuman.khandual@arm.com>, <linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH v5 3/7] perf record: Move setting dummy tracking before record__init_thread_masks()
Date: Tue, 15 Aug 2023 09:57:35 +0800 [thread overview]
Message-ID: <29111bbc-61af-4452-bf73-c3b32221989f@huawei.com> (raw)
In-Reply-To: <CAP-5=fV2u+HwxwuCmz0uSo_dvbFAwwjvK_QvkorB+qbtMnwtZg@mail.gmail.com>
Hello,
On 2023/8/15 4:29, Ian Rogers wrote:
> On Thu, Aug 3, 2023 at 11:58 PM Adrian Hunter <adrian.hunter@intel.com> wrote:
>>
>> On 4/08/23 05:07, Yang Jihong wrote:
>>> When dummy tracking go system wide, the mmap cpu mask is changed.
>
> As previously commented, can we improve the quality of the function
> names and commit messages? This sentence is particularly difficult to
> understand, I don't understand it.
OK. The commit messages will be modified. Please check whether the
following description is clear:
User space tasks can migrate between CPUs, so when tracing selected
CPUs, sideband for all CPUs is needed. In this case set the cpu map of
the evsel to all online CPUs. This may modify the original cpu map of
the evlist.
Therefore, need to check whether the preceding scenario exists before
record__init_thread_masks().
Dummy tracking has been set in record__open(), move it before
record__init_thread_masks() and add a helper for unified processing.
Thanks,
Yang
next prev parent reply other threads:[~2023-08-15 1:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 2:07 [PATCH v5 0/7] perf record: Track sideband events for all CPUs when tracing selected CPUs Yang Jihong
2023-08-04 2:07 ` [PATCH v5 1/7] perf evlist: Add perf_evlist__go_system_wide() helper Yang Jihong
2023-08-04 6:57 ` Adrian Hunter
2023-08-04 2:07 ` [PATCH v5 2/7] perf evlist: Add evlist__findnew_tracking_event() helper Yang Jihong
2023-08-04 6:58 ` Adrian Hunter
2023-08-04 2:07 ` [PATCH v5 3/7] perf record: Move setting dummy tracking before record__init_thread_masks() Yang Jihong
2023-08-04 6:58 ` Adrian Hunter
2023-08-14 20:29 ` Ian Rogers
2023-08-15 1:57 ` Yang Jihong [this message]
2023-08-17 12:27 ` Yang Jihong
2023-08-04 2:07 ` [PATCH v5 4/7] perf record: Track sideband events for all CPUs when tracing selected CPUs Yang Jihong
2023-08-04 6:59 ` Adrian Hunter
2023-08-04 2:07 ` [PATCH v5 5/7] perf test: Update base-record & system-wide-dummy attr expected values for test-record-C0 Yang Jihong
2023-08-04 7:00 ` Adrian Hunter
2023-08-04 2:07 ` [PATCH v5 6/7] perf test: Add test case for record sideband events Yang Jihong
2023-08-04 7:07 ` Adrian Hunter
2023-08-04 2:07 ` [PATCH v5 7/7] perf test: Add perf_event_attr test for record selected CPUs exclude_user Yang Jihong
2023-08-04 7:08 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29111bbc-61af-4452-bf73-c3b32221989f@huawei.com \
--to=yangjihong1@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®