From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752523AbeAQJ4X (ORCPT + 1 other); Wed, 17 Jan 2018 04:56:23 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:37676 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752430AbeAQJ4V (ORCPT ); Wed, 17 Jan 2018 04:56:21 -0500 Subject: =?UTF-8?B?UmU6IFvmraTpgq7ku7blj6/og73lrZjlnKjpo47pmaldIFJlOiBbUEFU?= =?UTF-8?Q?CH]_irqdomain:_provide_useful_debugging_information_for_irq_domai?= =?UTF-8?Q?n?= To: "Yang, Shunyong" , "tglx@linutronix.de" Cc: "linux-kernel@vger.kernel.org" , "Zheng, Joey" References: <1516163877-32396-1-git-send-email-shunyong.yang@hxt-semitech.com> <210f90d0-1588-2185-4845-d5d143183621@arm.com> <1516181177.3280.13.camel@hxt-semitech.com> <1516182426.3280.19.camel@hxt-semitech.com> From: Marc Zyngier Organization: ARM Ltd Message-ID: <2917770a-63b3-96ce-e4d5-a3152c7885f9@arm.com> Date: Wed, 17 Jan 2018 09:56:18 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1516182426.3280.19.camel@hxt-semitech.com> Content-Type: text/plain; charset=gbk Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 17/01/18 09:47, Yang, Shunyong wrote: > Hi, Thomas, > > On Wed, 2018-01-17 at 10:33 +0100, Thomas Gleixner wrote: >> On Wed, 17 Jan 2018, Yang, Shunyong wrote: >> >>> >>> Hi, Marc and Thomas, >>> >>> Thanks for your feedback. >>> >>> On Wed, 2018-01-17 at 10:18 +0100, Thomas Gleixner wrote: >>>> >>>> On Wed, 17 Jan 2018, Marc Zyngier wrote: >>>>> >>>>> >>>>> In all honesty, I'd be more inclined to remove this debug >>>>> feature >>>>> altogether, as CONFIG_GENERIC_IRQ_DEBUGFS is more complete and >>>>> more >>>>> useful. Is there any feature missing from that infrastructure >>>>> that >>>>> prevents you from using it instead? >>>>> >>>>> If the answer is "none", then I'll post a patch removing it. >>>> Wanted to do that quite some time ago and never came around to >>>> it. >>> I think they have different purpose. >>> irq_domain_mapping is an overiew of the mapping of each virq to >>> hwirq >>> and the domain it belongs. It likes a map or index of each IRQs. I >>> tend >>> to suggest to keep it. >> And how is that different from: >> >>> >>> The nodes under debugfs irq/irqs describes information of every >>> single >>> irq. >> Not at all. It contains the complete hierarchical information of each >> virq. >> > I think irq_domain_mapping can provide some high-level information in a > summary style. > For example, we can check all the IRQs connect to a specific irq chip > or irq domain. You mean, something like this: root@flakes:/sys/kernel/debug/irq# ls -l domains/ total 0 -r--r--r-- 1 root root 0 Jan 1 1970 default -r--r--r-- 1 root root 0 Jan 1 1970 gpio@e0080000 -r--r--r-- 1 root root 0 Jan 1 1970 gpio@e1050000 -r--r--r-- 1 root root 0 Jan 1 1970 interrupt-controller@e1101000 -r--r--r-- 1 root root 0 Jan 1 1970 v2m@e0080000-2 -r--r--r-- 1 root root 0 Jan 1 1970 v2m@e0080000-3 -r--r--r-- 1 root root 0 Jan 1 1970 v2m@e0080000-4 root@flakes:/sys/kernel/debug/irq# grep -r v2m@e0080000-2 irqs/| cut -f1 -d: irqs/49 irqs/48 irqs/47 irqs/46 irqs/45 irqs/44 irqs/43 irqs/42 irqs/41 Thanks, M. -- Jazz is not dead. It just smells funny...