From: David Howells <dhowells@redhat.com>
To: Himangi Saraogi <himangi774@gmail.com>
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org, julia.lawall@lip6.fr
Subject: Re: [PATCH] afs: delete double assignment
Date: Mon, 28 Jul 2014 16:29:58 +0100 [thread overview]
Message-ID: <2918.1406561398@warthog.procyon.org.uk> (raw)
In-Reply-To: <20140728152457.GA2901@himangi-Dell>
Himangi Saraogi <himangi774@gmail.com> wrote:
> - afs_uuid.time_hi_and_version = (uuidtime >> 48) & AFS_UUID_TIMEHI_MASK;
> afs_uuid.time_hi_and_version = AFS_UUID_VERSION_TIME;
>
> get_random_bytes(&clockseq, 2);
> afs_uuid.clock_seq_low = clockseq;
> - afs_uuid.clock_seq_hi_and_reserved =
> - (clockseq >> 8) & AFS_UUID_CLOCKHI_MASK;
> afs_uuid.clock_seq_hi_and_reserved = AFS_UUID_VARIANT_STD;
This might be the wrong thing to do. I wonder if the lines following the ones
deleted should be "|=" rather than "=". I'll have a look into it.
David
prev parent reply other threads:[~2014-07-28 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 15:24 Himangi Saraogi
2014-07-28 15:29 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2918.1406561398@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=himangi774@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome