From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F3AAC433DF for ; Tue, 20 Oct 2020 10:14:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF33C22282 for ; Tue, 20 Oct 2020 10:14:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405968AbgJTKOB (ORCPT ); Tue, 20 Oct 2020 06:14:01 -0400 Received: from smtprelay0062.hostedemail.com ([216.40.44.62]:35808 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2404581AbgJTKOB (ORCPT ); Tue, 20 Oct 2020 06:14:01 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 1B12E182CED5B; Tue, 20 Oct 2020 10:14:00 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: plane05_1115cb72723e X-Filterd-Recvd-Size: 3280 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Tue, 20 Oct 2020 10:13:58 +0000 (UTC) Message-ID: <291e3bbc22c84b18c54e072e995d18a7955a209b.camel@perches.com> Subject: Re: lib/crypto/chacha.c:65:1: warning: the frame size of 1604 bytes is larger than 1024 bytes From: Joe Perches To: David Laight , kernel test robot , Ard Biesheuvel , Steven Rostedt Cc: "kbuild-all@lists.01.org" , "linux-kernel@vger.kernel.org" , Herbert Xu Date: Tue, 20 Oct 2020 03:13:57 -0700 In-Reply-To: References: <202010190356.fgwA7zzR-lkp@intel.com> <80f9a6c79771167d119b2990910fe273c3901df0.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-10-20 at 08:00 +0000, David Laight wrote: > From: Joe Perches > > Sent: 19 October 2020 16:47 > > On Mon, 2020-10-19 at 03:13 +0800, kernel test robot wrote: > > > Hi Ard, > > > > > > First bad commit (maybe != root cause): > > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > > head: 9d9af1007bc08971953ae915d88dc9bb21344b53 > > > commit: 5fb8ef25803ef33e2eb60b626435828b937bed75 crypto: chacha - move existing library code into > > lib/crypto > > > date: 11 months ago > > > config: i386-randconfig-r023-20201019 (attached as .config) > > > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > > > reproduce (this is a W=1 build): > > > # > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5fb8ef25803ef33e2eb60b62 > > 6435828b937bed75 > > > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > > git fetch --no-tags linus master > > > git checkout 5fb8ef25803ef33e2eb60b626435828b937bed75 > > > # save the attached .config to linux build tree > > > make W=1 ARCH=i386 > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot > > > > > > All warnings (new ones prefixed by >>): > > > > > > lib/crypto/chacha.c: In function 'chacha_permute': > > > > > lib/crypto/chacha.c:65:1: warning: the frame size of 1604 bytes is larger than 1024 bytes [- > > Wframe-larger-than=] > > > 65 | } > > > | ^ > > > > > > vim +65 lib/crypto/chacha.c > > > > This seems to come from function tracing overhead. > > Are you sure? No. I'm trying to isolate it now. > I've not got the x86 object, but the x86-64 version caches the 16 x[] > values (from the parameter) in registers. > The 32 bit cpu doesn't have enough registers, but gcc tends to > compile assuming an infinite number. > So it may have spilled lots of virtual registers to different > stack locations - instead of writing the values to their 'target' > address.