From: Valdis.Kletnieks@vt.edu
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Bernhard Kaindl <bk@suse.de>
Subject: Re: PANIC: early exception 08 rip 246:10 error ffffffff810251b5 cr2 0
Date: Tue, 27 Oct 2009 02:23:19 -0400 [thread overview]
Message-ID: <29209.1256624599@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Mon, 26 Oct 2009 14:16:34 PDT." <4AE611B2.1030409@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2615 bytes --]
On Mon, 26 Oct 2009 14:16:34 PDT, "Justin P. Mattock" said:
> as of now in init_ohci1394_dma.c
> I did:
>
>
>
> void __init init_ohci1394_dma_on_all_controllers(void)
> {
> int num, slot, func;
>
> if (!early_pci_allowed())
> return;
>
> /* Poor man's PCI discovery, the only thing we can do at early boot */
> for (num = 0; num < 32; num++) {
> for (slot = 0; slot < 32; slot++) {
> for (func = 0; func < 8; func++) {
> u32 class = read_pci_config(num,slot,func,
> PCI_CLASS_REVISION);
> if ((class == 0xffffffff))
> + printk(KERN_DEBUG "putting a printk here keeps the machine from a panic\n");
> continue; /* No device at this func */
Try this instead:
printk(KERN_DEBUG "trying class=%d num=%d slot=%d func=%d\n",
class, num, slot, func);
if ((class == 0xffffffff)) {
printk(KERN_DEBUG "No device here\n");
continue; /* No device at this func */
}
The curly brackets are important. This version will still panic, and it will
probably spew a lot of msgs, but we'll hopefully find out which num/slot/func
is giving it indigestion.
> interesting thing here, is I just was wanting to see were this thing was
> crashing. when adding this in(above) Ill see a long string during boot
> for a few seconds and then the machine boots up.
> Now if I add a printk(example below) to here:
> if (class>>8 != PCI_CLASS_SERIAL_FIREWIRE_OHCI)
> + printk(KERN_DEBUG "putting a printk here keeps the machine from a panic\n");
> continue; /* Not an OHCI-1394 device */
> In dmesg I will see maybe 5 to 10 debug messages and then
> onto init_ohci1394_initialize.
That's because you forgot the curlies, and the 'continue;' is now unconditional
Now ou hit it *every* time, so you *never* do the test against
PCI_CLASS_SERIAL_FIREWIRE-OHCI and you never call init_ohci1394_controller();
And I suspect your *real* problem is something gone astray down in
init_ohci1394_conrtroller() - so if you change the code to never call it,
it never goes astray and you boot OK.
> keep in mind I'm not familiar with any of this, but just looking
> at the code I see 0xffffffff and searching(google) tells me
> that that's something with 32bit, should maybe there be something
> with 0xffffffffffffffffff 64bit?
No - it's "u32 class", so treated as a 32-bit.
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2009-10-27 6:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 23:45 Justin P. Mattock
2009-10-26 18:34 ` Justin Mattock
2009-10-26 20:29 ` Valdis.Kletnieks
2009-10-26 21:16 ` Justin P. Mattock
2009-10-27 6:23 ` Valdis.Kletnieks [this message]
2009-10-27 18:57 ` Justin P. Mattock
2009-10-27 19:07 ` Justin P. Mattock
2009-10-27 19:35 ` Valdis.Kletnieks
2009-10-27 20:34 ` Justin P. Mattock
2009-10-28 3:56 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29209.1256624599@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=bk@suse.de \
--cc=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®