From: Keith Owens <kaos@ocs.com.au>
To: Christoph Hellwig <hch@sgi.com>
Cc: John Hesterberg <jh@sgi.com>,
linux-kernel@vger.kernel.org, Robin Holt <holt@sgi.com>
Subject: Re: [PATCH] 2.5.43 CSA, Job, and PAGG
Date: Sat, 19 Oct 2002 00:37:50 +1000 [thread overview]
Message-ID: <29226.1034951870@ocs3.intra.ocs.com.au> (raw)
In-Reply-To: Your message of "Thu, 17 Oct 2002 22:44:10 -0400." <20021017224410.A25801@sgi.com>
On Thu, 17 Oct 2002 22:44:10 -0400,
Christoph Hellwig <hch@sgi.com> wrote:
>On Thu, Oct 17, 2002 at 10:21:47AM -0500, John Hesterberg wrote:
>> 2.5.43 versions of CSA, Job, and PAGG patches are available at:
>> ftp://oss.sgi.com/projects/pagg/download/linux-2.5.43-pagg-job.patch
>> ftp://oss.sgi.com/projects/csa/download/linux-2.5.43-csa.patch
>
>+#if defined (CONFIG_CSA_JOB_ACCT) || defined (CONFIG_CSA_JOB_ACCT_MODULE)
>
>Umm, stubbing stuff out based on _MODULE is a bad, bad idea. Just make it
>a bool instead.
The construct #if defined(CONFIG_FOO) || defined(CONFIG_FOO_MODULE) is
required for all CONFIG_FOO which can be defined as tristate.
.config Source code
CONFIG_FOO CONFIG_FOO CONFIG_FOO_MODULE
n undef undef
y 1 undef
m undef 1
If CSA_JOB_ACCT can be a module or builtin then the code is correct.
OTOH, if CSA_JOB_ACCT is a boolean subset of CSA then it should be a
bool, not a tristate. Given
if [ "$CONFIG_PAGG" = "y" ]; then
tristate ' Process aggregate based jobs' CONFIG_PAGG_JOB
dep_tristate ' CSA Job Accounting' CONFIG_CSA_JOB_ACCT $CONFIG_PAGG_JOB
fi
and assuming that CONFIG_PAGG_JOB=y, CONFIG_CSA_JOB_ACCT=m is a valid
combination, then the code is correct.
next prev parent reply other threads:[~2002-10-18 14:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-17 15:21 John Hesterberg
2002-10-17 16:21 ` Dave Jones
2002-10-17 17:50 ` Robin Holt
2002-10-17 18:52 ` Dave Jones
2002-10-18 2:33 ` Christoph Hellwig
2002-10-18 19:05 ` John Hesterberg
2002-10-21 19:43 ` Christoph Hellwig
2002-10-18 2:44 ` Christoph Hellwig
2002-10-18 1:07 ` Andi Kleen
2002-10-18 1:22 ` Robin Holt
2002-10-18 14:37 ` Keith Owens [this message]
2002-10-18 22:00 ` Christoph Hellwig
2002-10-18 15:43 ` Keith Owens
2002-10-18 16:19 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29226.1034951870@ocs3.intra.ocs.com.au \
--to=kaos@ocs.com.au \
--cc=hch@sgi.com \
--cc=holt@sgi.com \
--cc=jh@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®