From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754091AbcETOPz (ORCPT ); Fri, 20 May 2016 10:15:55 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:55009 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbcETOPw (ORCPT ); Fri, 20 May 2016 10:15:52 -0400 From: Arnd Bergmann To: Mark Brown Cc: Andy Gross , Felipe Balbi , David Brown , Peter Chen , Greg Kroah-Hartman , Alan Stern , Bjorn Andersson , Linux Kernel list , linux-arm-msm , linux-soc@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [RFC 4/8] usb: phy: move TCSR driver into new file Date: Fri, 20 May 2016 16:15:27 +0200 Message-ID: <2923003.R6AlEiEkj2@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160520124414.GK8206@sirena.org.uk> References: <1463606653-325131-1-git-send-email-arnd@arndb.de> <5468592.H0dRIBAxrx@wuerfel> <20160520124414.GK8206@sirena.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:vG0vLAcimtOnOLB0HY8q6Q7lps/0GKvqLswHblmm1yHsry9l7cA 5IGAm8Ac3r857N3GMJw/xxXZX1AzH3aZwYZLtnarr6+PEGPRe1xP+RQ4ZgUDrqoDuRLHycX lINr1sBMt1Rh4v0fE0NMxLRFnYfvE1Zdjxh+r15rByun3lpNW4ZkZ74zFCjzf5ZbyugCwsv 6vowoRptCGvb8O7WcCiww== X-UI-Out-Filterresults: notjunk:1;V01:K0:c3m9Vv3HE0A=:HQY36xcilPokJjGhjP0X8P mP9ZzLGhW7WRHmLAkc4pLUNUw2FXM0LLXuTmKSRrik0f3XJhIEaq/UK/0cFg9As/kiEqUGLy0 yjGVOe+qXF+P1Yfcp9U/pZwmDvTWcj9Hcjkoes2rNLU5JoQJ7Ly2T6S+PoNkgo2ij3Zogr+aJ wESpKnYDQI5eJTZBxbdHBda7NjagQToqKV9l0H2Ux+V9N9GFTmN0Nw36wylg5rG94aL9RMQCa G0Xj8ERt4prIVAwjE+WO3C57f2Ks+u23lUs7UGPEVIT4B7RsPWseFrtFIhwnusmyyyMgeWTxU /o7/1f7Gr2eyQtg+OJMVt9j4XDCxArxUXdTr5p/q+Bgluk12QegLxca37oGgQd8+52Vby3v0c BPW3TKX05THJUKx5AeWyub3CS+NmQXlZueZwIVnq5SbCYA3B058YupD7IPzuxuRaPsHTHxeBo y8JfhV66PNA4zIWF+I+xwlC7GzCcMoVxFUDBM8C7WMQLf+2CjerSpoVlf/tXNspdifZJWf4pO IMuAyabAdaXICZYCXp9Ase6EfS51eZJnnMpxPOTOhxK8f4iGkLWLmTbVdVZ8gGWyTcnq4XPis /qXNEWwEAHYaXvH0FERJjOZCntmopXCSV9FqclOxelPeXmMREjBynC7gx8iJfoVq5UnD+1+j3 WafUURZr6+Fb8DsQUKKo2iGPEbLNdiNcagUrxuYa8eaPE9bPh/T6jPmWGm/e+AxeGt4bmZeCd iNpje27KUgyaW+Or Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 20 May 2016 13:44:14 Mark Brown wrote: > On Fri, May 20, 2016 at 02:24:14PM +0200, Arnd Bergmann wrote: > > On Thursday 19 May 2016 14:08:43 Andy Gross wrote: > > > > I'd rather do something like what we did for the GSBI. It needed to > > > change some phy related bits in the TCSR as well. We defined the TCSR > > > as a syscon, with binding documentation under mfd. If we add a syscon > > > entry and use it if it is present, we can deal with that pretty > > > easily. The offsets change for each soc, and this would also fix that > > > issue because we can change offset based on tcsr compat. > > > Works for me, but be aware that this will break the server chips, > > as ACPI has no support for regmap devices. > > Just to be clear there's nothing precluding the use of regmap on ACPI > devices, it's syscon it doesn't have anything for. > Yes, that's what I meant. Arnd