From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933002AbcGLL2e (ORCPT ); Tue, 12 Jul 2016 07:28:34 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:46140 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932210AbcGLL2c (ORCPT ); Tue, 12 Jul 2016 07:28:32 -0400 X-AuditID: cbfee61a-f79106d000000835-00-5784d45d24fb From: Bartlomiej Zolnierkiewicz To: Colin King Cc: kernel-tram@lists.ubuntu.com, Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Sergei Shtylyov Subject: Re: [PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time Date: Tue, 12 Jul 2016 13:27:26 +0200 Message-id: <2928643.x6ZsLjxZ9e@amdc1976> User-Agent: KMail/4.13.3 (Linux/3.13.0-79-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1468322179-9398-1-git-send-email-colin.king@canonical.com> References: <1468322179-9398-1-git-send-email-colin.king@canonical.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFLMWRmVeSWpSXmKPExsVy+t9jQd3YKy3hBm9Walr8Xt3LZtF3+Aa7 xbEdj5gsLu+aw2ZxZtUtdotfy48yOrB5zGroZfN4MPU/k8emVZ1sHtdu3Gfx+LxJLoA1issm JTUnsyy1SN8ugSvj5dx7jAV3uSomtR1ia2A8w9HFyMkhIWAi8frdDFYIW0ziwr31bF2MXBxC ArMYJR5v/8oO4XxllHg2aSYzSBWbgJXExPZVjF2MHBwiApoS588VgdQwC6xjlHi/6TjYJGGB UIlDnYvB6lkEVCUalkxnAbF5gep33WtmA7FFBbwkerY/YgSxOQU8JJZdfgVWLyTgLvFz7go2 iHpBiR+T74H1MgvIS+zbP5UVwtaSWL/zONMERqAzEcpmISmbhaRsASPzKkaJ1ILkguKk9FzD vNRyveLE3OLSvHS95PzcTYzgEH8mtYPx4C73Q4wCHIxKPLwLSlrChVgTy4orcw8xSnAwK4nw LroEFOJNSaysSi3Kjy8qzUktPsQozcGiJM77+P+6MCGB9MSS1OzU1ILUIpgsEwenVANjuWHL W8vHbK1MeyPmLcl9Jc0npR9k9Hm3+cIZbVNUwhyvc6oKpa94kpBSstmjLvCR3a+a+RY+Fz+3 JAb8cr2sf3aWrWz+21relZMqbKs5dl1ZFvXqwL5i8/JTZgqH7rh382peaYqJrVz9wXDZn5QF L9f+KBd3TBDZ6PZ22SuTkHnT1yyU/3tViaU4I9FQi7moOBEALR1uEm0CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday, July 12, 2016 12:16:19 PM Colin King wrote: > From: Colin Ian King > > According to the HPT366 data sheet, PCI config space dword 0x40-0x43 > bits 11:8 specify the primary drive cmd_high_time, however, > currently just 3 bits of the 4 are being used because the mask > is 0x700 and not 0x0f00. Fix the mask, allowing for the 40MHz clock > to be detected. > > Signed-off-by: Colin Ian King Acked-by: Bartlomiej Zolnierkiewicz Thanks for the patch, could you also fix also the old driver (drivers/ide/hpt366.c)? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/ata/pata_hpt366.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/pata_hpt366.c b/drivers/ata/pata_hpt366.c > index e5fb752..a219a50 100644 > --- a/drivers/ata/pata_hpt366.c > +++ b/drivers/ata/pata_hpt366.c > @@ -368,7 +368,7 @@ static int hpt36x_init_one(struct pci_dev *dev, const struct pci_device_id *id) > > /* PCI clocking determines the ATA timing values to use */ > /* info_hpt366 is safe against re-entry so we can scribble on it */ > - switch ((reg1 & 0x700) >> 8) { > + switch ((reg1 & 0xf00) >> 8) { > case 9: > hpriv = &hpt366_40; > break;