From: "libaokun (A)" <libaokun1@huawei.com>
To: <arnd@arndb.de>, <mpe@ellerman.id.au>, <benh@kernel.crashing.org>,
<paulus@samba.org>, <linuxppc-dev@lists.ozlabs.org>,
<linux-kernel@vger.kernel.org>
Cc: <weiyongjun1@huawei.com>, <yuehaibing@huawei.com>,
<yangjihong1@huawei.com>, <yukuai3@huawei.com>
Subject: Re: [PATCH -next] powerpc/spider-pci: Remove set but not used variable 'val'
Date: Tue, 15 Jun 2021 10:00:29 +0800 [thread overview]
Message-ID: <29287300-6b6b-1773-a950-61ea20f1959c@huawei.com> (raw)
In-Reply-To: <20210601085319.140461-1-libaokun1@huawei.com>
ping
在 2021/6/1 16:53, Baokun Li 写道:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> arch/powerpc/platforms/cell/spider-pci.c: In function 'spiderpci_io_flush':
> arch/powerpc/platforms/cell/spider-pci.c:28:6: warning:
> variable ‘val’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> arch/powerpc/platforms/cell/spider-pci.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/cell/spider-pci.c b/arch/powerpc/platforms/cell/spider-pci.c
> index 93ea41680f54..a1c293f42a1f 100644
> --- a/arch/powerpc/platforms/cell/spider-pci.c
> +++ b/arch/powerpc/platforms/cell/spider-pci.c
> @@ -25,10 +25,9 @@ struct spiderpci_iowa_private {
> static void spiderpci_io_flush(struct iowa_bus *bus)
> {
> struct spiderpci_iowa_private *priv;
> - u32 val;
>
> priv = bus->private;
> - val = in_be32(priv->regs + SPIDER_PCI_DUMMY_READ);
> + in_be32(priv->regs + SPIDER_PCI_DUMMY_READ);
> iosync();
> }
>
next prev parent reply other threads:[~2021-06-15 3:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 8:53 Baokun Li
2021-06-15 2:00 ` libaokun (A) [this message]
2021-06-15 8:18 ` Arnd Bergmann
2021-06-18 3:51 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29287300-6b6b-1773-a950-61ea20f1959c@huawei.com \
--to=libaokun1@huawei.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=weiyongjun1@huawei.com \
--cc=yangjihong1@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®