From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CC752E645 for ; Sun, 7 Dec 2025 07:50:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765093843; cv=none; b=LPxCat1fMpRdd39G6WR5fwnXG29VuNEVb8bQvZ/HtXeSfjJdA3wVqIhqeBjBLvC4kD+WGfraiYbY7sOBszPxv4dVoNeNbCkiEwH0q0orgvekwnNHk1TB52KJ+Hpj5Bc/Y2zthukXjM3Gr7wEaBgcCBjjpN5hkdWddNYLYZmVmPM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765093843; c=relaxed/simple; bh=lR2XHjP45Tsp5fd5+x/EEratk7N46D2fz/PM0w7A9N8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KFL/EjYzLfkC7yh8ZbXll//vzaFulXxp6y5Dp0JR4qw1oqX/EjgbkECVo4U5wVJACr+9fxZfv9MQ83ojCjZKlen4kTC/31H3hp8RPbCycjDLKNt6oPy8bHfnr9IVTTx8/OsqCnZBxfjj8vxJur+UEiyJy8oHtEQJx3SI8+oB+xU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LUQaYoID; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V2qj5sjn; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LUQaYoID"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V2qj5sjn" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B74d3WS1155130 for ; Sun, 7 Dec 2025 07:50:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MzttGYYaYezC63L6aU8F+tDRvyhNUIysIPNry4BSqlE=; b=LUQaYoIDsr/u7+Cx 48rWOTdMPUvyZu4KfWkF0YJ03flF89+spC97rOrvUytJIBV/YOYBX1lTCCzxpxi6 NQbl0sEJYOVxpFppZtCXGIaFvR+J6qDDvl6OAjlsn8lt8Ep3OdfzFGXqSk8fysQ8 Ai2/35FZ5sMuP97WXFhJ4EPR98eHyyAJwl6bllvzhP8+HjI48qcP5e0iGkJWlc4I GxMkK7K20uve0gVv5kgADWN0phx2TdHdydJzDefW1G55AlFsv94FBV2dWeOgyQSm 6/puZNFhu1p34DUNAyqvTurKccWbrybOg1m9LzxiH1KpooB3SsmocYj0VhZ5UvZ5 ISGvrA== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4avcndt3wg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 07 Dec 2025 07:50:40 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-7d24bbb9278so7020445b3a.0 for ; Sat, 06 Dec 2025 23:50:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765093839; x=1765698639; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MzttGYYaYezC63L6aU8F+tDRvyhNUIysIPNry4BSqlE=; b=V2qj5sjnEjezcZSHDzPAn1udN5khpLolNWJxmP7Pvxo3h08mbu5YREJ5gnw7YmwGCt oTIZUXV4PqrPP/SpH78TjdQvLdE3GMVuFeXjpK2pROCEyqDOKX0BZvcE6C9nFriloFin m6DDC6j+AOYHhUwCFwvaqF1zjQsT1lMetaelZttngEMKou2N/kBQHE585bUlmAvUogI6 GCvNan7Cnbvdg/NBIIifnF3ayguugq8epshIvK4S0Kh2ApORlEiAT6eU9UImr2zyQbK6 JzywQH/V6dsNytSOb3+oTV1a36NKWDPJkHCYYVA0hZ98HvogscIXjgvakaxHfooBw7BU wWoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765093839; x=1765698639; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MzttGYYaYezC63L6aU8F+tDRvyhNUIysIPNry4BSqlE=; b=laDXH9XRfrR6msDTBEe8d32qKdU1bojcntG+H9XNN++8U6uyYt7wB+Qq4zIXj8EhIO iXQRQPjPhA7KhG1uUuT3ZU20PbkLdFRgnv26sZLL29w+SMH4RBdbxAB6+++NiVntSpQy SYSXvlNPWVM6gAtLTVS0VlhJI9UmsUvrcL1ElIEDJnnrRzF6GhXxPFb6cQBYvI/thmcx ihKfWG/Tt348bvK9YCB6w/SpAIuv0iLaSgphYUtzKdmEgawIuOaM+aemB46HM95t3Vss RoNgiHs3GbImXsOmEFQfoCYZqMRlgOywztEESjJEHEfnESajIFi0lbFOofdtE3Mq72YN 1+Lg== X-Forwarded-Encrypted: i=1; AJvYcCV/SPQ0GOPtEdmpzV2umuENeMZZFC8qrGb4iMzgTVU7RBzGA7l0gliCwmZw+iohsq4OyrvN9sUlT1TslIQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxrLHbVR6xOVOCPlzaRQim7XqB/lRxrpdXaYTTUXYH9SjFXELBv j/+DfwPoq0fOokThAO+/SE8WbSlyMfOdEUAa/xKDDZUd6cGbEpyRdjxfi/Yb3+pc6EMWomZUtHS 6GgQskA9YWxRMm5ilRn/RpiPbjyl6IIlxmcTUpDe7XPkKXrSU1hh8YhSjx98VB030dtU= X-Gm-Gg: ASbGncsi4AiyZGlpJ+U2gM7ubSohWw/BMl8T8REoHRvEq2wXsciculp66dNnV3LRSMq 1MJalnYkXVS7PF3/fmvijDvUVbrxB6eCpNa/ehKMuPh0z0+VPUUTkzcfENrxd2+aGdKMcRkSVVf QZ7ViWdsKTRkXviF3rm3QuFLeAaCsCz/sJFs6uxqyewUWG+0xlykoUQCI01xHEcJiWkjZWoa1H7 6vjZSWEbEWZ2KZKrkupYikndRkC76Jwtq+Ax8auiVCiNa+R9BAz2PwKo6F13JNT74XkxBgFt2NQ IxYL/rQ4feA6fiYlJSHnh9lol9Iokb6wm6/ePqq07GEhJ6xyV0h54cdeJUQrWlpyPOtcd2zLW9p /hDDi17Aa+DX6WcxRzUtQjiq4ylukw6wve6LLwfeM X-Received: by 2002:a05:6a00:2e13:b0:7aa:a2a8:980f with SMTP id d2e1a72fcca58-7e8c109c67cmr4252498b3a.20.1765093839425; Sat, 06 Dec 2025 23:50:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IGmq5igauuj4gfG0V+L29Alx/C+aLgg5lZwDZY7VdpjpIMy2DUHIEo9/7YEYuxflwHiHG8HJQ== X-Received: by 2002:a05:6a00:2e13:b0:7aa:a2a8:980f with SMTP id d2e1a72fcca58-7e8c109c67cmr4252481b3a.20.1765093838903; Sat, 06 Dec 2025 23:50:38 -0800 (PST) Received: from [192.168.29.116] ([49.37.148.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7e29fb94c05sm9714446b3a.16.2025.12.06.23.50.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Dec 2025 23:50:38 -0800 (PST) Message-ID: <292a9bd4-1125-4bd8-912f-003df3e3d2e1@oss.qualcomm.com> Date: Sun, 7 Dec 2025 13:20:33 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: defconfig: Enable QCOMTEE for Qualcomm SoCs To: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , Sumit Garg , Jens Wiklander Cc: Amirreza Zarrabi , Arnd Bergmann , Geert Uytterhoeven , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org References: <20251205-qcom_qcomtee_defconfig-v2-1-c92560b0346e@qti.qualcomm.com> <7ffb61c8-465c-40f1-b794-4f573c8f96ec@kernel.org> <4d4a6614-9460-48b4-8e6a-77d3395abfbf@oss.qualcomm.com> <083ebd3c-6d19-44c4-9a46-f7fba01111bf@kernel.org> Content-Language: en-US From: Harshal Dev In-Reply-To: <083ebd3c-6d19-44c4-9a46-f7fba01111bf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: X6g8SFKbFuyuPkF_VR7bri4qLt3D_hv0 X-Authority-Analysis: v=2.4 cv=baJmkePB c=1 sm=1 tr=0 ts=693531d0 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=v+kbWGyw1T97G6+vs1uYIQ==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=e7tGCk18dwv191QOjiwA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: X6g8SFKbFuyuPkF_VR7bri4qLt3D_hv0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA3MDA2OSBTYWx0ZWRfXzursoD6LG2x8 V+uC3MEjMFjNvJUR1kppdCY0d/0AFIyv2NYwCD8CE6Zrc2KT7ci6CRZZRkS0X7uQpV9G77QyZey 0FdRuYwGB+HS/95JXEK0MriBLwlc47cC1pWig2aEYxO+Qk+44mkTWjZb7A8A5kkPgzNYZIfYjVC FjJnbb5Fenk9Is8OOPX6blCrkCi8mb5lzFjHFjk9FIHkV9ieeIWOPzABhND6S9RjY4qRdoeFlUy ZkKwvkZ8Rpy0OanrELXKGpdo6X7hGspb8aW4MZfQaFv6NuO+eFQ9F7/9Lk94CY7l+T2hvPQPrui zeKK84KLOyaxAfdufaipLdhbZNcJYT7NuDg4/KQfz2UwifDEA7ps7/TCSJ70BVn5sinCGRbJJBu kn8cSgnr7jHYBudpI0YQ1d6i4ZIJXQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 spamscore=0 bulkscore=0 suspectscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512070069 Hi Krzysztof, On 12/5/2025 4:42 PM, Krzysztof Kozlowski wrote: > On 05/12/2025 11:58, Harshal Dev wrote: >> Hi Krzysztof >> >> On 12/5/2025 1:45 PM, Krzysztof Kozlowski wrote: >>> On 05/12/2025 09:12, Harshal Dev wrote: >>>> Enable config 'm' for the QCOMTEE driver to facilitate communication with >>>> the Qualcomm Trusted Execution Environment (QTEE) on Qualcomm platforms. >>> >>> I can do it forever, but next time I will just NAK. >>> >>> Which platforms need this? Which platforms use this? >> >> Looks like I misunderstood your comment on the last patch regarding Qualcomm >> platform support for this driver as more of a generic question instead of being >> a hard request to update the commit message. >> https://lore.kernel.org/all/f20833a4-1571-41f8-875a-d27086be3090@oss.qualcomm.com/ >> >> I will take care of this now, however I am still a bit confused regarding how many >> platforms should I explicitly list out in the commit message. I took reference of > > Just mention which UPSTREAM boards (which you called Qualcomm platforms) > use this driver. It's enough to mention one, for justification of > commit. You can mention two as well. Or three. > Thanks for this clarification Krzysztof, since the driver is related to SoC firmware and not on the board, I will mention SM8650+ as the supported SoCs since we began enabling the driver from that chip on-wards. I hope this reasoning is fine. >> these below patches merged earlier in the defconfig for enabling the QCE crypto block driver, >> Qualcomm Watchdog driver and Qualcomm RNG driver. And I did not see them listing out >> any specific Qualcomm platforms which need/use these drivers. I understand that this is >> because the drivers provide generic functionality applicable on all Qualcomm SoCs. >> https://lore.kernel.org/all/20220921045602.1462007-5-bhupesh.sharma@linaro.org/ >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f27dbbda5900c20e07418c6893ca6e95b634f4ff >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2774e558151a6e325e1f9f278722479601319f78 > > :) unfortunately all poor examples. And from 2019! You can find many > poor examples in the kernel - in commit msgs or code. You can find many > obsolete drivers written in old, not updated style. These are not > examples to be based on. > > Usually it is the best to take LATEST reviewed code, not something 6 > years old, so the process would be: > > tig -- arch/arm64/configs/defconfig > /Qualcomm > (or whatever search query you want) > Which would give you commit c5d02bbaa217b2454ba1ce7528113aa2ecf14f3c > from June for example. It even caries two review tags. > I appreciate you taking the time to provide this advice. Acknowledged. :) >> >> Similarly, all Qualcomm SoCs have ARM TrustZone support with a QTEE firmware OS running. >> The version of the firmware might differ, but it is always there, and so the QCOMTEE driver is >> applicable to all Qualcomm SoCs just like the Watchdog or RNG driver. > > You can say that all Qualcomm platforms use it... but I would challange > it, because not all platforms use watchdog or RNG. > Sure, let's not do a 1-1 comparison between watchdog/RNG anc QCOMTEE. Regards, Harshal > Best regards, > Krzysztof