From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCD2BC433E1 for ; Fri, 24 Jul 2020 09:16:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B9BB2063A for ; Fri, 24 Jul 2020 09:16:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728048AbgGXJQ6 (ORCPT ); Fri, 24 Jul 2020 05:16:58 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:55302 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726979AbgGXJQ5 (ORCPT ); Fri, 24 Jul 2020 05:16:57 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 3490F7D3B18E53A0A185; Fri, 24 Jul 2020 17:16:55 +0800 (CST) Received: from [127.0.0.1] (10.174.178.56) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Fri, 24 Jul 2020 17:16:45 +0800 Subject: Re: [PATCH -next] arm64: Export __cpu_logical_map To: Anshuman Khandual , Catalin Marinas , Will Deacon , Mikko Perttunen , Sumit Gupta , Viresh Kumar CC: Hulk Robot , "linux-kernel@vger.kernel.org List" , References: <20200724030433.22287-1-wangkefeng.wang@huawei.com> <82f750c4-d423-1ed8-a158-e75153745e07@huawei.com> <7998529f-da52-5e46-dd09-b9b11d83ec1a@arm.com> From: Kefeng Wang Message-ID: <292c907e-f08d-8a89-9148-802995e92ef3@huawei.com> Date: Fri, 24 Jul 2020 17:16:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <7998529f-da52-5e46-dd09-b9b11d83ec1a@arm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.178.56] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/7/24 16:16, Anshuman Khandual wrote: > On 07/24/2020 08:38 AM, Kefeng Wang wrote: >> +maillist > This does not seem to be a correct method of posting any patch. sorry， forget to cc mailist when git send-email >> On 2020/7/24 11:04, Kefeng Wang wrote: >>> ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined! > >>> ARM64 tegra194-cpufreq driver use cpu_logical_map, export >>> __cpu_logical_map to fix build issue. > Commit 887d5fc82cb4 ("cpufreq: Add Tegra194 cpufreq driver") which adds > this particular driver is present just on linux-next. But as expected, > the driver does not use __cpu_logical_map directly but instead accesses > it via cpu_logical_map() wrapper. Wondering, how did you even trigger > the modpost error ? arch/arm64/include/asm/smp.h:#define cpu_logical_map(cpu) __cpu_logical_map[cpu] Will see the error when using allmodconfig to build. > >>> Reported-by: Hulk Robot >>> Signed-off-by: Kefeng Wang >>> --- >>>   arch/arm64/kernel/setup.c | 1 + >>>   1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c >>> index c793276ec7ad9..3aea05fbb9998 100644 >>> --- a/arch/arm64/kernel/setup.c >>> +++ b/arch/arm64/kernel/setup.c >>> @@ -275,6 +275,7 @@ static int __init reserve_memblock_reserved_regions(void) >>>   arch_initcall(reserve_memblock_reserved_regions); >>>     u64 __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = INVALID_HWID }; >>> +EXPORT_SYMBOL(__cpu_logical_map); >>>     void __init setup_arch(char **cmdline_p) >>>   { >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> > . >