From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<rafael@kernel.org>, <viresh.kumar@linaro.org>,
<robh+dt@kernel.org>, <krzk+dt@kernel.org>
Cc: <matthias.bgg@gmail.com>, <jia-wei.chang@mediatek.com>,
<roger.lu@mediatek.com>, <hsinyi@google.com>,
<linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH V2 01/15] dt-bindings: cpufreq: mediatek: Add MediaTek CCI property
Date: Mon, 11 Apr 2022 14:48:59 +0800 [thread overview]
Message-ID: <292e5b8df8a011fdbb9c271e39ba927c6076484a.camel@mediatek.com> (raw)
In-Reply-To: <0ef8f2c3-fd16-041b-3304-b167a2a36ff9@linaro.org>
On Fri, 2022-04-08 at 13:49 +0200, Krzysztof Kozlowski wrote:
> On 08/04/2022 12:24, Rex-BC Chen wrote:
> > >
> > > You need to describe the type. I am a bit confused whether this
> > > is a
> > > cci
> > > (so cci-control-port property?) or an interconnect (so
> > > interconnect
> > > property)... It does not look like a generic property, so you
> > > need
> > > vendor prefix.
> >
> > Hello Krzysztof,
> >
> > Thanks for your review.
> >
> > Yes, this cci is not arm's cci (cci-control-port property), and
> > it's
> > mediatek's cci. I will revise this name to "mtk-cci" in next
> > version.
>
> Vendor is "mediatek" and comma comes after it. See devicetree spec
> paragraph 2.3.1.
>
Hello Krzysztof,
OK, I will revise as "mediatek,cci" in next version.
> >
> > >
> > > > + For details, please refer to
> > > > + Documentation/devicetree/bindings/devfreq/mtk-cci.yaml
> > >
> > > Such file does not exist.
> >
> > This mediatek cci is still upstreaming in this patch:
> > message-id:20220408052150.22536-2-johnson.wang@mediatek.com
> >
> > Do you have suggestion that I should put this reference?
> > Or I just remove it and describe the mediatek cci in detail?
>
> It's ok, but you need to keep path/filename updated.
>
>
> Best regards,
> Krzysztof
From your comment of cci series.
I will write is to be
"Documentation/devicetree/bindings/devfreq/mediatek,cci.yaml"
Thanks!
BRs,
Rex
next prev parent reply other threads:[~2022-04-11 6:49 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 4:58 [PATCH V2 00/15] cpufreq: mediatek: Cleanup and support MT8183 and MT8186 Rex-BC Chen
2022-04-08 4:58 ` [PATCH V2 01/15] dt-bindings: cpufreq: mediatek: Add MediaTek CCI property Rex-BC Chen
2022-04-08 8:10 ` Krzysztof Kozlowski
2022-04-08 10:24 ` Rex-BC Chen
2022-04-08 11:49 ` Krzysztof Kozlowski
2022-04-11 6:48 ` Rex-BC Chen [this message]
2022-04-08 4:58 ` [PATCH V2 02/15] cpufreq: mediatek: Use module_init and add module_exit Rex-BC Chen
2022-04-08 13:36 ` AngeloGioacchino Del Regno
2022-04-11 3:17 ` Viresh Kumar
2022-04-08 4:58 ` [PATCH V2 03/15] cpufreq: mediatek: Cleanup variables and error handling in mtk_cpu_dvfs_info_init() Rex-BC Chen
2022-04-08 13:36 ` AngeloGioacchino Del Regno
2022-04-11 3:20 ` Viresh Kumar
2022-04-08 4:58 ` [PATCH V2 04/15] cpufreq: mediatek: Remove unused headers Rex-BC Chen
2022-04-08 13:36 ` AngeloGioacchino Del Regno
2022-04-11 3:21 ` Viresh Kumar
2022-04-08 4:58 ` [PATCH V2 05/15] cpufreq: mediatek: Enable clocks and regulators Rex-BC Chen
2022-04-08 13:36 ` AngeloGioacchino Del Regno
2022-04-11 3:22 ` Viresh Kumar
2022-04-08 4:58 ` [PATCH V2 06/15] cpufreq: mediatek: Record previous target vproc value Rex-BC Chen
2022-04-08 13:36 ` AngeloGioacchino Del Regno
2022-04-11 11:35 ` Rex-BC Chen
2022-04-11 3:26 ` Viresh Kumar
2022-04-11 11:33 ` Rex-BC Chen
2022-04-08 4:59 ` [PATCH V2 08/15] cpufreq: mediatek: Move voltage limits to platform data Rex-BC Chen
2022-04-08 13:36 ` AngeloGioacchino Del Regno
2022-04-11 11:18 ` Rex-BC Chen
2022-04-08 4:59 ` [PATCH V2 09/15] cpufreq: mediatek: Add .get function Rex-BC Chen
2022-04-08 4:59 ` [PATCH V2 10/15] cpufreq: mediatek: Make sram regulator optional Rex-BC Chen
2022-04-08 13:37 ` AngeloGioacchino Del Regno
2022-04-08 20:32 ` Kevin Hilman
2022-04-14 10:53 ` Rex-BC Chen
2022-04-14 17:20 ` Kevin Hilman
2022-04-08 4:59 ` [PATCH V2 11/15] cpufreq: mediatek: Update logic of voltage_tracking() Rex-BC Chen
2022-04-08 21:08 ` Kevin Hilman
2022-04-14 11:30 ` Rex-BC Chen
2022-04-08 4:59 ` [PATCH V2 12/15] cpufreq: mediatek: Use maximum voltage in init stage Rex-BC Chen
2022-04-08 13:37 ` AngeloGioacchino Del Regno
2022-04-12 11:24 ` Rex-BC Chen
2022-04-14 3:40 ` Rex-BC Chen
2022-04-08 4:59 ` [PATCH V2 13/15] cpufreq: mediatek: Link CCI device to CPU Rex-BC Chen
2022-04-08 13:37 ` AngeloGioacchino Del Regno
2022-04-11 11:50 ` Rex-BC Chen
2022-04-08 20:54 ` Kevin Hilman
2022-04-11 11:51 ` Rex-BC Chen
2022-04-11 12:31 ` Rex-BC Chen
2022-04-11 18:13 ` Kevin Hilman
2022-04-12 12:26 ` Rex-BC Chen
2022-04-12 18:50 ` Kevin Hilman
2022-04-13 11:32 ` Rex-BC Chen
2022-04-13 21:41 ` Kevin Hilman
2022-04-14 2:32 ` Rex-BC Chen
2022-04-14 21:48 ` Kevin Hilman
2022-04-15 2:31 ` Rex-BC Chen
2022-04-19 18:16 ` Kevin Hilman
2022-04-08 4:59 ` [PATCH V2 14/15] cpufreq: mediatek: Add support for MT8186 Rex-BC Chen
2022-04-08 13:37 ` AngeloGioacchino Del Regno
2022-04-08 21:10 ` Kevin Hilman
2022-04-11 11:14 ` Rex-BC Chen
2022-04-08 4:59 ` [PATCH V2 15/15] cpufreq: mediatek: Use device print to show logs Rex-BC Chen
2022-04-08 13:37 ` AngeloGioacchino Del Regno
2022-04-11 3:29 ` Viresh Kumar
2022-04-11 11:09 ` Rex-BC Chen
[not found] ` <20220408045908.21671-8-rex-bc.chen@mediatek.com>
2022-04-08 13:36 ` [PATCH V2 07/15] cpufreq: mediatek: Add opp notification for SVS support AngeloGioacchino Del Regno
2022-04-08 20:29 ` Kevin Hilman
[not found] ` <3b7bf25a3da6c8f780c87784c1f796bf1e464238.camel@mediatek.com>
2022-04-11 18:09 ` Kevin Hilman
[not found] ` <dfe2d3e3401a6f2a7be9db4e8a0590d3dd9a6969.camel@mediatek.com>
2022-04-12 18:04 ` Kevin Hilman
2022-04-08 21:11 ` [PATCH V2 00/15] cpufreq: mediatek: Cleanup and support MT8183 and MT8186 Kevin Hilman
2022-04-09 1:05 ` Hsin-Yi Wang
2022-04-11 11:37 ` Rex-BC Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=292e5b8df8a011fdbb9c271e39ba927c6076484a.camel@mediatek.com \
--to=rex-bc.chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hsinyi@google.com \
--cc=jia-wei.chang@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=roger.lu@mediatek.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®