From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751111AbdBBGG4 (ORCPT ); Thu, 2 Feb 2017 01:06:56 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36846 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001AbdBBGGz (ORCPT ); Thu, 2 Feb 2017 01:06:55 -0500 Subject: Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix) To: Joe Perches , gregkh@linuxfoundation.org References: <20170128084910.7975-1-martinowar@gmail.com> <20170131192456.1221-1-martinowar@gmail.com> <1485902368.20550.37.camel@perches.com> <1485972712.2560.11.camel@perches.com> Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Martin Karamihov Message-ID: <2933ae60-bc8a-278e-b81e-03924de72182@gmail.com> Date: Thu, 2 Feb 2017 08:06:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1485972712.2560.11.camel@perches.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/01/2017 08:11 PM, Joe Perches wrote: > ...and clarifying the code for a > human reader is much more important than making a > file not have any checkpatch warnings. I agree. I respect the developers' own coding style and believe that some things (>80 characters long lines, name conventions, etc) should be fixed by themselves (if they want to do that). I selected several TODOs with requests for code cleanups and chose a fix in attempt to accomplish my task with minimal inconvenience for the maintainers. I failed in my first attempts breaking some basic rules, sorry about that. Martin