From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B5B6C4321E for ; Mon, 10 Sep 2018 17:53:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BD482086E for ; Mon, 10 Sep 2018 17:53:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BD482086E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728100AbeIJWtF (ORCPT ); Mon, 10 Sep 2018 18:49:05 -0400 Received: from gloria.sntech.de ([185.11.138.130]:45382 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726603AbeIJWtF (ORCPT ); Mon, 10 Sep 2018 18:49:05 -0400 Received: from wd0180.dip.tu-dresden.de ([141.76.108.180] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fzQNa-0004lY-6R; Mon, 10 Sep 2018 19:53:42 +0200 From: Heiko Stuebner To: Manivannan Sadhasivam Cc: robh+dt@kernel.org, vicencb@gmail.com, shawn.lin@rock-chips.com, ezequiel@collabora.com, enric.balletbo@collabora.com, pbrobinson@gmail.com, tom@vamrs.com, dev@vamrs.com, stephen@vamrs.com, amit.kucheria@linaro.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] dt-bindings: arm: rockchip: Add binding for Rock960 board Date: Mon, 10 Sep 2018 19:53:41 +0200 Message-ID: <2934145.U5auXtDNYt@phil> In-Reply-To: <20180910172655.GA4191@Mani-XPS-13-9360> References: <20180910151356.25946-1-manivannan.sadhasivam@linaro.org> <1606406.b630GQBvc1@phil> <20180910172655.GA4191@Mani-XPS-13-9360> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 10. September 2018, 19:26:55 CEST schrieb Manivannan Sadhasivam: > Hi Heiko, > > On Mon, Sep 10, 2018 at 07:22:26PM +0200, Heiko Stuebner wrote: > > Am Montag, 10. September 2018, 17:13:54 CEST schrieb Manivannan Sadhasivam: > > > Add devicetree binding for Rock960 board from Vamrs Limited. > > > > > > Signed-off-by: Manivannan Sadhasivam > > > --- > > > Documentation/devicetree/bindings/arm/rockchip.txt | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt b/Documentation/devicetree/bindings/arm/rockchip.txt > > > index acfd3c773dd0..aaad9e2ff9a3 100644 > > > --- a/Documentation/devicetree/bindings/arm/rockchip.txt > > > +++ b/Documentation/devicetree/bindings/arm/rockchip.txt > > > @@ -5,6 +5,10 @@ Rockchip platforms device tree bindings > > > Required root node properties: > > > - compatible = "vamrs,ficus", "rockchip,rk3399"; > > > > > > +- 96boards RK3399 Rock960 (ROCK960 Consumer Edition) > > > + Required root node properties: > > > + - compatible = "vamrs,rk3399-rock960", "rockchip,rk3399"; > > > > hmm, are there more boards labeled rock960 from Vamrs? > > Because I'm trying to determine what makes "vamrs,rock960" unsuitable. > > > > Not that I'm aware of but the intention was to follow other RK3399 based > boards. Anyhow, I have no issues with "vamrs,rock960" if you prefer it! yep, I think I would prefer it :-) Looking at the bindings we have, it seems we really have some sort of mix, but I guess most boards with a real name, just use this one, like all the google boards or also the ficus itself. Most of the others are eval boards and fireflys, where the board is actually unnamed and just uses company name + soc :-) Heiko