From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19F253E317C for ; Tue, 9 Jun 2026 09:59:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780999174; cv=none; b=ajqI6kf1Zn4kJiRvmKXVe2g4Dgq07PdM172yvYHOi99dhWaIyJCcD3US9kXDe1K9nMoKfSO41W3NC2nhm6fIu+Ad2iJDAczbwu2BrJeT2gkugncErv+ie1GYYDBT99xUcf0oJqmn/6KwYtTTEPvtgwX46nzN7ZWHFSAslCt6Xqo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780999174; c=relaxed/simple; bh=tqpllveE1TCdfBkjG5qxZyc+XJkW3yVqJZ0BRe92+ag=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jiz3wBm/r+AL/+y9+lf0eeCmNbr2UYrFfxsy6GqNtQJPt7CXnyuHRyjPgySQve7PyfCqx8M3+CANpUpnJmsLh4KNJ8qfMtXx6WcLs5oiAXFFdITxsKtAwvE1rKygBrVj8vjXY1cemgEfPMpoDHXUm4mn53F3+vNImNEHGUDDi/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qjpC2etS; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qjpC2etS" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5aa6c66e6c5so3224521e87.2 for ; Tue, 09 Jun 2026 02:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780999171; x=1781603971; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CbGlbm349sPXsDxdYe2/wkkzZXDv3DztWFkPZAETkkg=; b=qjpC2etScZpehDLlsv33oGEzMGa1zgm+Y0z3yPPRilcEEXbeJumfWLwJL0UcTBmcZ8 jGnNbiuhoe8HTasvm7d9g5j9bG8RE4zaPhir7R7ZNsLtdMmp+wtv0VOH/uPlolcuhCyv 8PjwOkt6kt0PGv8cvZwj/P4Arv8UM9VXauccmur1jx0empERfQSJlXpzfwVi5hRRP39b 9pyaweLRHJQKQVagUwnXdwFiZahcGQXGHyPVQUbTEOa+ghTaH5AUmY9Lkj1COfdor57H zX9/r3m/k4PNsORaZvoROP01XSCW69qw9a7F0+UvA9DcsJaTNOE4hEjpkS61/kBLND5x V+Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780999171; x=1781603971; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CbGlbm349sPXsDxdYe2/wkkzZXDv3DztWFkPZAETkkg=; b=iGtgPMLLXMSIF6mME4QDYpL2ssj398KVGc6pso8IWG9GorUZLuPPf4ydvGxkkc6e4U q61zRzwOjF4trtXcHe54H7XIuqIbnt6+4i6ul1lRpeG99PchcHRWCQdxs1EvH9gzsCcm 8xoRV9o+nNNGLyfgF59TuwIFPWlbZo2Ux5PYxawNm5rVtyBfr0zD6A4A/YOjxFMTjLaZ WciF1iD0aTj8fWU0x/HVnhL/rrBcZr5auY3yhtLDA+vJqQ6Q5xQSBmtia0GuBnJyMfru uaEiCBs+qQIS4FynVoiq5jPt5gSRpvbDyG8zM5rvxkqyIJi6FtMvuRb1RfxvnYl2JxTi dnlA== X-Forwarded-Encrypted: i=1; AFNElJ+P3JyHeCSu5U223la1H8xLZawA9EP6VC+XQBPH5gkfCoZxoaDH0NgNOGHSb3WpgyYbzWkQxwissW/k/oM=@vger.kernel.org X-Gm-Message-State: AOJu0YzY225DgJpKFq7WfOBwvYfjTLAp35n6QGJxRivgNMUHRy617BdR wVVr4/3JN6qpV72yiSAZst3DxLVGKjFlZuJSjoBsJN++SC1d+aMVxnbD X-Gm-Gg: Acq92OH700WCi6fMFjd96+OxGXsiB4saPL672h48TVsu5Pq1ZJMr8VYJ673x9z5042k LTUxqnANg6TBCFAIHDlk3JqOVRJDCaDtx1K0fLoUwpmg5wS1ZhnBQ5iT7sXRYmepD1zYn6sbJjw z3aeAhnbDqCYe8N8ZqjfJdeFd2fFvsBhdXtJBW2yERamqEZzjG9g+uQ7/59O7JqcZWvajkb9pIq IK3uBnlUar3z/V2Nhn7aMD34t/WsWnc16mJUxIhXbi4kz+FHyIpBbwxTe7vb74agi2sfI5iMelz BO+NxRxHdUOHZSHg+4NfkDGQfsRKAVVAOAQ1lwX13Vlphc+x/8fPdyG+bOFqz3ybqYPUrE96hf/ YdvyJPIFniNu6nUYRx7D6Z1HZxr9D1lqzd6cn9DTGvOjFlqtdXYO/NAI7QlTUtnFUkVCEsfK4uh 8qPkTzRN/lnLq9MzYz0WMvqHLqTzymYrqBvZJfH6QkXEcYY+mFk5t6f9Gd6HqujCfiyHCtOaKqH pI1L/bxS8sfWRcq62o= X-Received: by 2002:a05:6512:3b9a:b0:5aa:6c7c:65d2 with SMTP id 2adb3069b0e04-5acf6be849amr663307e87.11.1780999170801; Tue, 09 Jun 2026 02:59:30 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa7b9079f7sm4466364e87.37.2026.06.09.02.59.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 02:59:30 -0700 (PDT) Message-ID: <29343d3a-38db-4f28-aed2-59e36d4354f8@gmail.com> Date: Tue, 9 Jun 2026 12:59:29 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: pressure: bm1390: replace short msleeps with usleep_range To: Andy Shevchenko , Jonathan Cameron Cc: Hungyu Lin , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260607140018.59586-1-dennylin0707@gmail.com> <20260608184154.72a88788@jic23-huawei> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/06/2026 09:13, Andy Shevchenko wrote: > On Mon, Jun 08, 2026 at 06:41:54PM +0100, Jonathan Cameron wrote: >> On Sun, 7 Jun 2026 14:00:18 +0000 >> Hungyu Lin wrote: >> >>> Replace msleep(1) with usleep_range(1000, 2000) for the >>> driver's short delays. >>> >>> The BM1390 datasheet specifies a 1 ms reset cancel wait time >>> (tSC1) during the power-on sequence. Use usleep_range() for >>> these short delays, as it is more appropriate than msleep() >>> and avoids unnecessarily long sleeps. >> >> Use fsleep() which has the added advantage of standardizing the >> 'slack' so we don't have to thing about the values chosen > > While true, msleep(1) is kinda idiomatic, we don't need to hunt subtle timing > issues in case of switching to stricter fsleep(), which will most likely choose > usleep_range() beneath. TL;DR: I do not see a value in this change. > I don't see the value either, unless there is a real problem the patch author has encountered. If there is a real world problem this is solving - please state it. My stance on fsleep() Vs. msleep() in ASYNC probes can be read from discussion (bikeshedding) between me and Nuno ;) https://lore.kernel.org/all/14a23df0e1828b72b8b03c358980fe08a12bb216.camel@gmail.com/ Yours, -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~