From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751760AbdBAKSb (ORCPT ); Wed, 1 Feb 2017 05:18:31 -0500 Received: from mail-eopbgr10103.outbound.protection.outlook.com ([40.107.1.103]:10160 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751243AbdBAKS3 (ORCPT ); Wed, 1 Feb 2017 05:18:29 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; Subject: Re: [PATCH 1/2] iio: pressure: mpl3115: do not rely on structure field ordering To: Peter Meerwald-Stadler References: <1485936567-3367-1-git-send-email-peda@axentia.se> <1485936567-3367-2-git-send-email-peda@axentia.se> <8eba97cc-69e5-3698-ddf3-d6eca0bcd3f8@axentia.se> CC: , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Alison Schofield , Gregor Boirie , Sanchayan Maity , Ken Lin , From: Peter Rosin Organization: Axentia Technologies AB Message-ID: <2936f505-79d9-340e-4454-ec7ef0bc7236@axentia.se> Date: Wed, 1 Feb 2017 11:18:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [217.210.101.82] X-ClientProxiedBy: AM5PR0601CA0027.eurprd06.prod.outlook.com (10.173.86.141) To AM5PR0202MB2548.eurprd02.prod.outlook.com (10.173.89.9) X-MS-Office365-Filtering-Correlation-Id: 444edc85-535e-44d3-7453-08d44a8ba795 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:AM5PR0202MB2548; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;3:9WoJ9gbS+fKk0gXADIkKhHoQr2lxmoTwAeIN3ic9sGmvuVJsFIvsESzD2af3bEO/zHS+iWLYKSLgYLgvYO/Zztq/9c0qPNJmwR1Vugro7bCgT6WnlIDFQMmkzxnxNHP0y5MHMguBlb/UDX5lSLZKNTLVVj91fNbqj+4B+L2ng87h9QKaXF4GbTnzsE1WAM8zZ+q+6VgwYokIt1Yl4oKHBUAcZsPRE0bZvSneXM0LW+6Oi8DG97iduGW/rRFXEUzkECngTRAFqHbzEa+b3xukbQ==;25:QhtRKfm4BF9dGzYQSIUI0eE2SVHBMvyM2LIKFYB/EvWHDJBs3KAjsytnmxSIVcnqBH9EjagWXMY2EDYxfc4pISiOQRGIeQTAq3Xy6A5NV0PYpkkvXinmiSwpkhn54QDKyw+T76P3pyF1iYPiTYhGI1z5VOPGh6joUOk537vtFRAqfBsgVQtJkByl+A329hhJvJc6FaNU6mS9qtR2LCVzsDKOqhNAJ9pfBbmUXLoYJVomtWN+2e7E7jTwKHOLubX+kb7aiXrU2mFv0M6arrOauzN4nLmACd/8DIuZfx73tVQXKq5C6cDDhvhmT/S2dzEZzS2xX93eEu+yYVGkADGPpSWNKoU1XH9q4TEKKL11mxYtbYOmKaEfBiq+iF6MbtwKp+NF59ugwQrqKghhs3h17465TZ1eCzv94pFDKtGTrjxt+tOLhhBaHUgrao39uV8YzgIHoMRVdVEjuWrrX/f1Cg== X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;31:sV76A9fZypVP+A/oRQh17auOgljLuxbngDDM6ERvoYps4WU9HWPABw9MqVrfxxSHARO22iU9D459pjFzh7nekA8Ski+0c9pmyxNFHmJLtWPOhgLsaI+G7gKkYG+bz1Zd+CVqCZZWlfQBJbDa8Iub5Chr/tccBGYVzY04ubAcwx9HXvop3yA4nDnz0PHMHRc34BxA2FFv5XzYTZtCvJO+dqQojX7J3tBKAz4c1ZRRcPfUIwrUYjZDfvIgFmmTi4cT0+yDhEEh3TTuA/LJKV1PBdv+FkKHcFOVTWuPl2ogl7I= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123564025)(20161123562025)(20161123558025)(20161123560025)(2016111802025)(20161123555025)(6072148)(6043046);SRVR:AM5PR0202MB2548;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0202MB2548; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;4:lBiFhW5TalV/scMOKprgbKY2OfC462IzBHwIghbw8GXQgZxPaby+enSDTbxqXC0Wr6fGmBW/KpqefyttxhG5M0hPqjlIUTtH4nuJUNrcoWDKdXK/EiDUwtNFav8jqKl4fdwExuVjnh8Jv4iX0E3/Kc0QXKxL+qiKRq+NdBqBfyWiqVAoP50+/ctH4OlrhOxcD88HOf324s9hW+OWfRFKVC0m9M+TT5lCPK/gy41Cekeu9gTucXeWxFK/Yy1QWGlba7olvITxO48fV3PMI/iv46eGOBni2XgLCifEEp5cwrQ84QN/80miNt0jti7vBRMgbJHPatHy7OqmL1w6P4+P6HjRbL1Mo+WlpyaY9YxOOok84/OO1V9/m2UT15YygOyFtpqgGHcOQgqvgn9H34ErpqH+8wtVupm1Mc1XQgU2tWiCO92gWpkLouqk3Da5Cr8yxprIxseB8q1CyfwAYlpCHlmeAVnjBzesje9PM++c1rAoOUVBSfA4oJBXapbFaof4s2QptG3ePWRhBWWWIDCgcq3jwiCeS0C+HA3RVoO5HaGcnaN8/ksQ9b6Rr6uGtZ4rpeLWmPihn6Un1FSYXOztm0iO71VIo5Arq1evTbm8/YgbsmZIKUu3hF/zbnbXrbUL3RJWSvxa3NPNduq3TXcH6v7mGGEbfi4+6PEugJm+Yck= X-Forefront-PRVS: 0205EDCD76 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(39830400002)(39450400003)(39410400002)(377424004)(199003)(24454002)(189002)(39060400001)(53936002)(7736002)(189998001)(83506001)(77096006)(65826007)(92566002)(305945005)(66066001)(65956001)(23746002)(93886004)(8666007)(54906002)(25786008)(5660300001)(47776003)(6486002)(68736007)(6916009)(229853002)(110136003)(38730400001)(2950100002)(65806001)(90366009)(50466002)(106356001)(50986999)(4326007)(31696002)(105586002)(86362001)(36756003)(230700001)(74482002)(31686004)(6116002)(3846002)(7416002)(64126003)(101416001)(8676002)(33646002)(117156001)(76176999)(81156014)(42186005)(81166006)(54356999)(97736004)(4001350100001)(2906002)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:AM5PR0202MB2548;H:[192.168.0.125];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM5PR0202MB2548;23:rrVR4H2dsi3HwDmsFIZoVFtF5K9yGP8mDZe?= =?Windows-1252?Q?PwxN8x/7ZgPAuZKvMEC5JASTT3dqmUD7k7qB7dD+mzPR0aaLlB4XNGzK?= =?Windows-1252?Q?1irS2m/EsT+u/I+miwPer5NnH5NXj0APuLauQ4dOiVzXN4mpdM9xH4pb?= =?Windows-1252?Q?K9y7UoalUB7vNQXx++3NfbV+pU3J7CKQoJBOaDDTHwnFjWmiLh18iMtz?= =?Windows-1252?Q?AFEIOVKVls1vX4Y4o6Rm9QPR4CZHfaEpf5tH9oa4ULJe3FgDRDycnaue?= =?Windows-1252?Q?buywbLfDa/GG7CQ8KoWHoJlfNqw7L7bVrhRoOT2izzkcIJaxqi/HeAHC?= =?Windows-1252?Q?txHbh7eGpfDH7KLbbRqiN7EvHhPWIUBCEmPL0jHIwL8K+WbbH7mFXOzX?= =?Windows-1252?Q?/taAt/fWXf9UC0Zfvvkh/Xcso5MLmqkS2AF4CCQQyuyQ5yHAxzybuYjA?= =?Windows-1252?Q?4h8vJjhnzCh2hapyMnqo+7DO8MHKvm1igaivm8AY/b11gb5sfAlI9btP?= =?Windows-1252?Q?guR/++TvuJBON/u4yup/yCDTiBbSrVW6oSjSaDcI4DExoW6KzXSL86Qi?= =?Windows-1252?Q?pCcOTK4kdB5fJARsQchi6hTSGHsWRhZ9FFEm+9XPTfRBN4Agv2WXql8J?= =?Windows-1252?Q?47hRL40FfBXr3KTHyKEHQGxrN1myekgqIVtX7Xcq5lI9jwtc8nCjeYsG?= =?Windows-1252?Q?baedFQMVa6d8C5gEThXxjcE0QDTXKgsnTQ1SnY6cGcROLdxTq4QRykGM?= =?Windows-1252?Q?d9wS+9a1bVu6Nh7MrsxH+2e5zjrwkNZTMpRBHcQefKSshD054qYLoddm?= =?Windows-1252?Q?8l5Cd17c/5hJe5Xkn9dJUoKKkzHNiguJ9GKaW7BpONkR2WBqtkpR5DKg?= =?Windows-1252?Q?Pn6uZjWwgi37cB21liD9dHRudtfZN0+ZyzrkNLx2SGcwz9VZ/8wyAmbH?= =?Windows-1252?Q?GYBEikMmXHpq/bOvetcidZvuyS8gY9vPSW1d1AqtdHySp0L/L9YyUBFD?= =?Windows-1252?Q?fFSQnm3qIoV46Xabq83uG1KiwVSg9vdU8WEPxFOLwoDRhpKzO7r9XeKq?= =?Windows-1252?Q?efnCLpxJ6K0j46BieuLKLKfi6p1VP0aPR2hS4i1vD+Oi+LFejcfCn60G?= =?Windows-1252?Q?CM1ns7hiUP58guivPoOf6lG2E23265dvB5QlopgvKYGd5l96qp2B5+5H?= =?Windows-1252?Q?O/sbSAgcSfleziAg7GQP/y1yZbzxTkMDPJLvppm41R5UBxdZ96FO+XFn?= =?Windows-1252?Q?dQvDaKoJ4J7Mcd3fu0x1dXVTRWiJFTrI9GO/OPFScMkGgTPuklC/Zmwd?= =?Windows-1252?Q?A71smlZwo6h1JUfqVWbC6MEEZ/v/wwIFykdCDr+jbtpXhgebEijn3W3t?= =?Windows-1252?Q?zWOJxrr8+RpZCWLhul15ANPkFhvTFEGyUnnku3wruQbDpGzizTUGRGHn?= =?Windows-1252?Q?ybIiakg6+jv/RnvJwHjH2D3Jo5zESGtdsIBhANvV4uI7n+C8uwulZ1ad?= =?Windows-1252?Q?pfPqB5kThansOo09dBfgUuUR5yDXsHqXVgxiMbqLH5JK3r489GtsIJ6g?= =?Windows-1252?Q?Kczm15XjIGMVR2Wj10/luOZ8Lxlx7V1u7J1cUtf2QWkkUfug9oqqtSHB?= =?Windows-1252?Q?R0IWBzyP4yHyZF7Sgxmy9IqcWFCdwQOMrS+V5dKDxEaHV0cZW0c/dpew?= =?Windows-1252?Q?ooJNa2mGnzivbFSunb6nPCFWFQwEGdO0=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;6:xV0/DM7v2Aw+VWWcA8BL+EiUcagzyPtAQu0hAqlT+HBDG8xDoEU7DVha+sXKRpin/JqjQqaASwlMhWLadwSKN/hM0RDjpcgsBfGwjFZ3l2Odbsbc8IuMuPvcJWpPIvlCX0BRnxFYJOcivwraA+mSiCnPnIUBj4BQ2H0szZJx6LAPeJqvx5nvs6PppIqqFQMM/f+dyp99YxukfR54g9f/1FIMV4H+JT4Djoy4quwdDhqz1liXhZQYdjzzyw9Wr4yd4bKqWOVn45rIkg0F4cPVoYg//ucNbTbDxqc/j210SYat4A2IU938N3JJzl9zhR17uD/7GbjO32k9AoHtg9rNg8tF+hVWNABd+VY/4qkBLKd1Jnnt2nzKbUkO39WL4vMqroQBzYnnCyScVMVHn9M+N4opRg1TtJj1LGd+FsSHuy0=;5:M2snanuah61TnPV+yrs2jK5wsAH2Ga8WPlysBFRHRnjWxft6Vgo0/fNZ3wL3aMv9WBrjNiosx3Wf3jRR3V8EADmFae+WGBhsv8SU1CSxSNj23bRlVhprKtQomVcgEp75CLCp2KagU6TKQF82mcUwmA==;24:7sOF467VpU+lRKuzUBmBmYl59SpA7qNbjzMdIicRCsatQkT3ZDThO8MtyCs2oycYH4tioEjj06AcepGjq9XPS1jBrBDhdNF61QtxTBf1WkY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;7:5Z594rBRedlAf2p1u7dRD8Cfa0kFcnzzFLb9XuqpmXogfWDEviIB7PcPXlOKl3Hx7aO6d6uoIVtj6TP/KR9bQwCLxOdaxw07JQ6B6OIlAZ1t9M9wrW2lUgoOijPRZuBth//qK2qtlycNDTvkrF/msztx0PIiAg9aG9PdQeJxrw+JYhvyWXhFu0dlunLWkEzpps7xXCwG1Ur1InH7Or2Qt6B3x+qwDyarp7VKdiJpim9HKXBrfLyydV0Vf49lHZDFaFdhJHEDZrcK6/aL3v0w3NCGWlsJ0WABqKYpUOmN6O1M1al/p9uGVYhE02SqMDsgBE9HdvgQ50WZBihKIhoLe2+sMSoQYHRZSb4kxbTxlSznKm6mnXkC4B9nCRk4HdQHlv/eqxmyYYDIZ3YPZFDCSOwWnOrq6uwpDUxH8mIUtX9gRWC0bB2elxlMJSTRfzk426Wai72LpekHdouKuvKNxfoEKIQiBS8AH2gBaQt3KGEDk2gs7Ek5zjgcKZ4xiFcOmSmbEN2iXI5MPoT0fqkbN1PK8HePb0rx4CEHUG1iPF5yLOemTo1cdYFm9FQpNFRW X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2017 10:18:23.0545 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0202MB2548 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-02-01 10:57, Peter Meerwald-Stadler wrote: >>> - .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), >>> BIT(IIO_CHAN_INFO_SCALE), >>> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | >>> BIT(IIO_CHAN_INFO_SCALE), >>> as originally intended >> >> I considered that option, but the code in mpl3115_read_raw (and >> mpl115_read_raw for that matter) return constants fro these values which >> to me indicated that they were not "separate" and as that would also be >> the change which replicated the exact behavior from before the regression >> I went with that. But I don't care either way, so I can re-spin if you >> want me to? (But don't blame me if that regresses in some other >> interesting way). > > no, all good; shared_by_type is the way to go > I'd rather respin for the not ORed comment in the patch Ok, but I think I'll wait a bit so that Ken Lin gets some time to verify that it actually solves the original problem. It should, but... Cheers, peda