From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 039C8257423 for ; Mon, 16 Mar 2026 09:22:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773652972; cv=none; b=u6YkyLY8r93PUtchSPemJpMS1ejQAJ3SuwomVZUWgDMNk672c6U3+VhXzhZI640q1/OLJSH5wuj11dNnCIZOJzdlz7QPjihIyD0J6p+IsYPcUh6o2C2CUCFE+Xfh3xBBXjKCLHhyT5+ebVhxYOyNwfRlyS5fvEWizp00hbn7JO4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773652972; c=relaxed/simple; bh=651N/ZWGUh7WndF2u0M+V+HCDJzdkexxeYE4ppvFvgI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LFhrKYIUmWnWJUR3hDh/wYkoNRX+0z0qOAX0Q41yyhSvAO61PKMGjwCk4tIyV8PTUCyfIP0XlI1hSS+1tL3qE/4+NB6KtXMXCjpLA+WqmxCZVpTOFTWpK8qkxBC+46s/P7aC0KIfDOcyqtTVjYQEZnORF38b8Vct4ErStTaSCls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RqQRjCvc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f/QucZyq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RqQRjCvc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f/QucZyq" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62G7mo46041517 for ; Mon, 16 Mar 2026 09:22:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UtWXTGagT/GGBueURbq9/nje29CFuwHmLEoPSvQmhuc=; b=RqQRjCvc0rawgpoE OTePQPjeAADE3fgu7fHeo9i2Fay09uLE6T86LJPMaB3aQQIeOMxodoe70h1PA/VA YDTofbhkFE5OEMMPQeakL0fWNsMZThM+PK/9clgZ1U2sQ/PV6az9bbnODqE2GbFG SiCFU2dUJQfuYyAt+Jk4E/9jYE2nyCrrTufFYMLseooGM7g/RmucvIdexnDP91dj 5IBMoqUJGyGrHyHyaVPiLtWqokxJgv0iJsR6vrTHVJYwlwdMHSliO546bpDTz/5P hYemKC5wdCdV74NcvUGMy2Ys6zfPDu4+3paH2XXvu1af7A/6fm9C12Z8OdZeo2z0 dWdp3Q== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxdt80avu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 09:22:49 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-89c49436edeso10844926d6.0 for ; Mon, 16 Mar 2026 02:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773652969; x=1774257769; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UtWXTGagT/GGBueURbq9/nje29CFuwHmLEoPSvQmhuc=; b=f/QucZyqBgoKmxfhHiZ/CczwvvLHIqhmijJmeSLXW6c9QKk/pApTmlY83kF5IoM8nW E/w94Xoy7EDFWzm3QOVzU04LY4zVOYUuDyhnnloGO7XWSV3iIHI+02Ypjf5TGMrGwJvP zLE5AORp6aDhmuUqgKeacb1cd3GVFpw7ztbboQ+ydQKNtT6fB/z1sZFT0aNp/M4/GwpK m/egJbR2BjNpqnBrRNrL6p/mo4YM6vdd9N7znLMBlX2MKydbrvsknq36HVCyrQMR8RKa t8ZOidVkK5ZTDKWWhy0W/gKmEp6PcaTBnKvM/z7Yfu6oXkSDVOwQfniId69xLBiCnTNY MUrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773652969; x=1774257769; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UtWXTGagT/GGBueURbq9/nje29CFuwHmLEoPSvQmhuc=; b=alNui8nXwX3Et3amxgspifc90JUGVzi5oKw649NzIj8KkZCBiTqROamfCpM8GfgIZX b5VZpnKOQkUnQma4AbbmgwfLv4uaf3SDuOuq25HADFtYplVpbrVKatfeJ06ytkP2UTQP 9f7MVxFHtdAKIUcNw30m3tQLtf/raLrosCK5KjJolaLEhO8NibtDwnErwjGE0mu5alyx kd8CEtxMMxwK3nj7ynsYPfHl+st3zxQ6h0eXC99vtcLV8ZL9bP96OWZm33P6ygO087ta XiKf3DM8jst9bK4C8OB/KBvm8etEBkwohfQOk6o9qbHMcQMko7SC/sznaSjZFZB+OrpI 7WvQ== X-Forwarded-Encrypted: i=1; AJvYcCVgOLCTl+mowW9sj6d803X7ftie79IdJfqOVhhLyiZjRzGenwo4LfSRaIHOODk6e+e13CREt/5+KJnKeZY=@vger.kernel.org X-Gm-Message-State: AOJu0YxReP9SrKjYeWYiMTEED9nBbI3VrDYF3rfxKxDCvmyaisXaj02J GS26pdopg1yKivlARx5x9IEkliXaiDcvNHT/dutYm/STK/UheQkw8ocbIkVLT5UdgGMZiYAUciv WSTGJn/PdHA+ww+CQtM7ewSeL5M/y5jLdmAUTLdfStvz7/g5A5Cm4w/61lBLqGyuCmfM= X-Gm-Gg: ATEYQzwoiKst3D5uUwJZYpULpZ086EWi+QUaH+JXJE8Xw1rmbIDY9Dw2iV3dQBz5zTY 7ZWVj1v6bE2Da1PXAs0EJUA7x7TfsMjIufbbzRc/ky40rFKV4OQF6Qvkyv6pclQQ8MXWuaqDtd2 bpUtcho1BNdJ85jXT3YeqYQoJWSV4bP8Mc8zcKyfz6s4RI9TBMSC0E4bmJG7+z4JBRO7VCXzAFu KHLm/NERWUSWfQ51XUYD4NZ4JAlv45jdFluVtJRr5S3F7j8lqX0exGqW1wVSbzqQtIioe3zkxKi DYEFotWBufAyPSRuWFASajRNnRppB2OSOzoQu163Jki87k9v2cBAyIlm0JbCE35mLdcBMaJChuT MJvXTyunHg1d3T0yvipiKXJzENkx7ZNFuOOjlYq2GxCjr7/LF+mdP4Ih3qqvZ3sJcKLU+uGKoKj ApB8w= X-Received: by 2002:a0c:f105:0:b0:89a:7d14:66d4 with SMTP id 6a1803df08f44-89a8203defbmr112828776d6.7.1773652969164; Mon, 16 Mar 2026 02:22:49 -0700 (PDT) X-Received: by 2002:a0c:f105:0:b0:89a:7d14:66d4 with SMTP id 6a1803df08f44-89a8203defbmr112828636d6.7.1773652968804; Mon, 16 Mar 2026 02:22:48 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b976cc220basm525813566b.28.2026.03.16.02.22.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 02:22:47 -0700 (PDT) Message-ID: <2938aa01-cc1b-4dd8-a4af-45ff8354a061@oss.qualcomm.com> Date: Mon, 16 Mar 2026 10:22:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm: Fix GMEM_BASE for A650 To: Alexander Koskovich , Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260314-fix-gmem-base-a650-v1-1-3308f60cf74c@pm.me> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260314-fix-gmem-base-a650-v1-1-3308f60cf74c@pm.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 9zHwNKL-UIRCvkJvocpLd-roQMsfxXEz X-Authority-Analysis: v=2.4 cv=CKInnBrD c=1 sm=1 tr=0 ts=69b7cbe9 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=e0mgrY8X18LXsc_zQXUA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-ORIG-GUID: 9zHwNKL-UIRCvkJvocpLd-roQMsfxXEz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDA3MSBTYWx0ZWRfX2uayRh4oS4SM 1IdtBGc2N8L34ywff5eXYJon/fCyBQVqZDGbsYyySZgk5k+042Cv1uQ9zuY96UaRI5OAMTOfd6k iUEY908dXuJpbJuznyppyJ7e5RXETaG9J7mzzyoqlhktXpybLhpt8Fgj+QJP6Yz01KY8C15Ze1r L+qqOHcdnsf+TSCQLy2yA7Szv9qOYWtXDTWmEFeDrAV20GVcHWyWd5TK6virX7qQOOQg5sP2m5O a4OL3vxE8g6oeyQcqKQtwH45YDan1sAZzulqvxJ2oHxAuVuErbDRMRcxQbmSc8IGv+Rgn8ADFP5 IVZLHUTM0/eUmRkQXT3PJAED0GXO6Q6u0VpiEV9i6PwCj/pe3yO8KRQ3JG6wTylgUqFdrNNcWw1 9wfP6i11VKG3zeC+5xEh5ardvZabuBIE6Jyv6k4Y6TnzqzO73lVpUxZDaD+3RJJ0dHYSmNcVJhC dWNO96SaTcpxSIAC7Hw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_03,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 phishscore=0 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160071 On 3/14/26 5:14 AM, Alexander Koskovich wrote: > Commit dc220915ddb2 ("drm/msm: Fix GMEM_BASE for gen8") changed the > GMEM_BASE check from adreno_is_a650_family() & adreno_is_a740_family() > to family >= ADRENO_6XX_GEN4. > > This inadvertently excluded A650 (ADRENO_6XX_GEN3), causing it to report > an incorrect GMEM_BASE which results in severe rendering corruption. > > Update check to also include ADRENO_6XX_GEN3 to fix A650. > > Fixes: dc220915ddb2 ("drm/msm: Fix GMEM_BASE for gen8") Hm, that commit also changed the value for A730 - Akhil/Rob, should that be changed back? Konrad > Signed-off-by: Alexander Koskovich > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > index d5fe6f6f0dec..0ac3fba5c277 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -376,7 +376,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_context *ctx, > *value = adreno_gpu->info->gmem; > return 0; > case MSM_PARAM_GMEM_BASE: > - if (adreno_gpu->info->family >= ADRENO_6XX_GEN4) > + if (adreno_gpu->info->family >= ADRENO_6XX_GEN3) > *value = 0; > else > *value = 0x100000; > > --- > base-commit: 1f318b96cc84d7c2ab792fcc0bfd42a7ca890681 > change-id: 20260314-fix-gmem-base-a650-cfd9bfcea425 > > Best regards,