From: Joe Perches <joe@perches.com>
To: Kalle Valo <kvalo@codeaurora.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v1 1/1] ray_cs: use %*ph to print small buffer
Date: Sat, 21 Aug 2021 12:38:49 -0700 [thread overview]
Message-ID: <293b9231af8b36bb9a24a11c689d33c7e89c3c4e.camel@perches.com> (raw)
In-Reply-To: <20210821171432.B996DC4360C@smtp.codeaurora.org>
On Sat, 2021-08-21 at 17:14 +0000, Kalle Valo wrote:
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > Use %*ph format to print small buffer as hex string.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Patch applied to wireless-drivers-next.git, thanks.
>
> 502213fd8fca ray_cs: use %*ph to print small buffer
>
There's one more of these in the same file but it's in an #ifdef 0 block...
---
drivers/net/wireless/ray_cs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
index 590bd974d94f4..849216fbb8363 100644
--- a/drivers/net/wireless/ray_cs.c
+++ b/drivers/net/wireless/ray_cs.c
@@ -2284,9 +2284,9 @@ static void untranslate(ray_dev_t *local, struct sk_buff *skb, int len)
DUMP_PREFIX_NONE, 16, 1,
skb->data, 64, true);
printk(KERN_DEBUG
- "type = %08x, xsap = %02x%02x%02x, org = %02x02x02x\n",
+ "type = %08x, xsap = %02x%02x%02x, org = %3phN\n",
ntohs(type), psnap->dsap, psnap->ssap, psnap->ctrl,
- psnap->org[0], psnap->org[1], psnap->org[2]);
+ psnap->org);
printk(KERN_DEBUG "untranslate skb->data = %p\n", skb->data);
}
#endif
next prev parent reply other threads:[~2021-08-21 19:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 14:29 Andy Shevchenko
2021-08-21 17:14 ` Kalle Valo
2021-08-21 19:38 ` Joe Perches [this message]
2021-08-22 5:08 ` Kalle Valo
2021-08-22 7:14 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=293b9231af8b36bb9a24a11c689d33c7e89c3c4e.camel@perches.com \
--to=joe@perches.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®