From: Johannes Berg <johannes@sipsolutions.net>
To: Greg KH <greg@kroah.com>, Wentao Liang <vulab@iscas.ac.cn>
Cc: luciano.coelho@intel.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] mac80211: Add null pointer check for ieee80211_link_get_chanctx()
Date: Mon, 26 May 2025 11:56:16 +0200 [thread overview]
Message-ID: <293fe5ea564a98113443bbe93e6022c5bb6dd747.camel@sipsolutions.net> (raw)
In-Reply-To: <2137c5905fc87e80698e6578ebf360be6d899f6f.camel@sipsolutions.net>
On Mon, 2025-05-26 at 11:50 +0200, Johannes Berg wrote:
>
> I still very much disagree with you and _will_ keep adding warnings to
> the wireless stack. This would be one of those places where it's totally
> warranted, because it's actually impossible that this happens, for it to
> something else would have to be changed to go wrong in how this is
> called, for example.
And come to think of it, cases like this are exactly why some people
decide to crash the system on warnings. It's things that the developers
thought were impossible, but should be double-checked. If we stop
putting warnings on such places, then the decision to crash on warnings
becomes entirely meaningless. So seems to me that just lashing out
against warnings all the time is actually detrimental to the intent of
such configurations?
johannes
next prev parent reply other threads:[~2025-05-26 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 9:19 Wentao Liang
2025-05-26 9:35 ` Johannes Berg
2025-05-26 9:44 ` Greg KH
2025-05-26 9:50 ` Johannes Berg
2025-05-26 9:56 ` Johannes Berg [this message]
2025-05-26 10:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=293fe5ea564a98113443bbe93e6022c5bb6dd747.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®