From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FB713F88B8 for ; Mon, 15 Jun 2026 14:44:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781534684; cv=none; b=LQ6LYrk/fWztpGvmnB09VR5uOnFadxbScWTfBQLVofcepH7tYWocVxygP3UYnTeEgqRRF/9hVA0ff7twscDHlf1iDsnDitBSILGKsG/w8PGnw7CwGrgkskP8fe+hawdaoKNUb/NoiOz7mjlpuvSVydnMLUqUnAv+mbgKYKjScw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781534684; c=relaxed/simple; bh=wVczAE4BvCr1c1Rw732n0oj3annxMP38/RrvE0NcFkU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tZl9oAVMba9DQJqx/LIHmeRBHn1Rr4q1W9lJtq5kiLCdvLWjCqRQCJQ8/MdiTz8ph34fWPnO5EzjUwN2ZxEJ9C738Z70/UxfN+F0QOCbj4917S27rZ3/UU4lKpLzhSC69SKhpHNdM+ruDSyg0Mj4zdRoH68kntPe0KlAKOvxD3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aROvyvhH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DGyf2VVi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aROvyvhH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DGyf2VVi" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FEZ2s9629001 for ; Mon, 15 Jun 2026 14:44:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xJJWeCn0xRFEnOpJ5bzTkC3VlDqzl5JZmrfiMpAiPkc=; b=aROvyvhH+/QCNVQG moNQovKnv5N6axedtHmISUAwJ6CZxHo6rI/6f9KxQnc+Y/cI4KKbe6YPsM7D89oU FWK6PkDu8jNt0/xguAZbsYDtOgtwOB2PXAXKFE0l27sDjdkwagHUN7PegiiPVHq7 in3QXDIVemj2+7SpJHlIsDFaEYdNXbfXooCzr/MysCMoN8KL6FS2MUzkdB5Dpnnd Q6UGf3xEZYPFmioh/rMqu1sBA0ycwVqBOuMpF9D5VRROBZxkCcXySIZkT9JbnvBr v9OKjWdhnXm2EL7w6T6d6wgxgHBSLE6nilMGnCn5SaTbA0Cn4gzGbtcah7Z7Tmwd SXmZWA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4etevx166v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 14:44:41 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-5175bf22b2bso4281901cf.2 for ; Mon, 15 Jun 2026 07:44:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781534681; x=1782139481; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xJJWeCn0xRFEnOpJ5bzTkC3VlDqzl5JZmrfiMpAiPkc=; b=DGyf2VViXRaHwm2o8k1Dzx16LBeK8KzZ6wCUFxFoIyTDpXCE2HhkwFVuk/7LPm8btR YrMxrpajA6kjvjEWVUcH+NeMwVWxWSIfrf4kZKc/3JE68ltDhX5OArAY5jp8xHM7c7Nv TQy4R7/ZQvwqh0Bm0WOjYtqipMLTMW08pkJ6aGGVUX9Pg0She4J8of4tnlr2m4g42B3p r+WyF2qdvWsAofMa4cH5alYGBNMmri96NeOrJztRS+NaAH/P67OpNyYlcv3EWPuQYmeQ tcDhbQAKuK6Kxxq2L+rofLxzBVAm6DTnGmjIUjmShCYbi1gNzpkeVRch6QCQDqBe5hXf cByA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781534681; x=1782139481; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xJJWeCn0xRFEnOpJ5bzTkC3VlDqzl5JZmrfiMpAiPkc=; b=czLAt/vBiVTlh6mK6FIS2ATEKSbDmJm+vkF53VTr1s9Y+2q9QEt5AP/2kqv5Q7GE+H PA1kr7F5cLoMy/ZJWEDplzlWOkLcdmru22WBEOzvPTx3Lih//k94yjpYNxjg+qD5mo0C 9A5aMIQfXa4a4/M7pjR1njE84aFDwCWyeXJbltthEvDeRMV7YD7m1JHfVgkeeSaLP4IW dFXNYyoPf7Epf8UkYj5Um52zPmV2dS/CaVYeRD295BuoY333THkaFxlZroK3SEnq+iwQ Qm7/eWS4N1WVBduU0V4c6IZhrBnpIUvJF7itB2TRDFH5XI8VDehNT736SSExeLHzZ0V8 k8Cw== X-Forwarded-Encrypted: i=1; AFNElJ/EGsFaOx4qDsaHQ+actxJqRcfB+xNdehNNrYyPDZrjF2QDejtPGHLW5LuYgs8ihk4GWhbjvj/3vAaHk0g=@vger.kernel.org X-Gm-Message-State: AOJu0YyOH2ZtJKrlEaiCAAIOKaWR8h8qWqIDAFdzZgmE7shlj+/I8dKg tlyzKAYjxOT3ViWFQS0a/QQZX5JgpP7m2P9UhvWjCtiZqz1DDiQJjvonYF3tqn+KD56tEa1dXAf bc6ipC753F4QI7svkOGSDpvgxzpcNFkj1Q4G5v/gj+TcRWrOOaKigB7lSUbPaeGcgrV0= X-Gm-Gg: Acq92OEjmeWRPfKL7jlx/P5IhfIEwQDUiFLwR19jn/9dKCRgPzWnkvwJn/VgAlkCJSP 4qbX7lcOh3es7dHjrIzFHgUdNnWy+cOXH64Tfx6beYoJ7GH5fWLbmbjdt8hoPNSO+Nv6aMk5IlU kh5S846UKUkkHfIFL2zTBNSeJN521bxm8NwAp4OWJI6zCp+rt7WhaN8hNbbMjSKvrfq63uaTsNr a8huxQFkLjscHeo30uY8SXwS2fDBl0TXMfRDNJ0xPDNg1stdKPVeLuNHdDoEIFbHMIb8OZvUPyq SExZOx5MSh1om3e7u4U41D5+oqzfNCNs1nZerbJ7K5QxwUM+t1clEiFXl8Yvqqt4FWLV3+Erx7Z 266ew1AkEhb0RFI89TGFH3NnkcxXbsZsqWkLiubDPoZexVg== X-Received: by 2002:ac8:5e06:0:b0:50d:a92e:fead with SMTP id d75a77b69052e-517fe50c57dmr138011211cf.3.1781534680829; Mon, 15 Jun 2026 07:44:40 -0700 (PDT) X-Received: by 2002:ac8:5e06:0:b0:50d:a92e:fead with SMTP id d75a77b69052e-517fe50c57dmr138010891cf.3.1781534680347; Mon, 15 Jun 2026 07:44:40 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb910f89bsm500939966b.61.2026.06.15.07.44.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 07:44:39 -0700 (PDT) Message-ID: <294012ad-1030-4c5f-8910-30ae4962b65a@oss.qualcomm.com> Date: Mon, 15 Jun 2026 16:44:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/12] clk: qcom: gcc-mdm9607: Drop incorrect apss_tcu_clk_src To: Stephan Gerhold Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Georgi Djakov , Shawn Guo , Bryan O'Donoghue , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260609-qcom-clk-mdm9607-fixes-v1-0-5e9717faf842@linaro.org> <20260609-qcom-clk-mdm9607-fixes-v1-7-5e9717faf842@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: JfnvhIxfB3mDbYCg80eAB5LS__HCP95c X-Proofpoint-GUID: JfnvhIxfB3mDbYCg80eAB5LS__HCP95c X-Authority-Analysis: v=2.4 cv=f8t4wuyM c=1 sm=1 tr=0 ts=6a300fd9 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=j8Cu_9a8AAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Ck7eFbc12gNnvPpTPzYA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=A2jcf3dkIZPIRbEE90CI:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDE1NSBTYWx0ZWRfXyqCoiRam8dNJ 0brOfEl4HlOQ3YzDZ63dECBXmw6TTK/Qr73YIWQwAHARe02hUrs/nEQaMmXz+H2Wh89vOFTLChQ srdyivLk4dSD4pwddRCT+UBZLoa5dbQ= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDE1NSBTYWx0ZWRfX2zQHfBZC+1MB SAjFOVbNOpIesVOs+ucMcLmd8QG9bYpQofjuMcWkBQvkjQ9kBz+wlhAoER0wEsvaTq6B99pDEY0 MeT1TUiZNfcRSpML08Juo2oXgytf/0oadY87cZh1IEH8yHtjFMpyFs8g8QmuxVND/ZCT1FmkuxK IswUJ0d/RrulCyt/B4bDSioBRpKXFLmT41hI//d84AnUF2ZdGlNglEeFsXNoe+MwUR5uqm6AmI4 yhIwIFD6TX1y5QI7V5c0XuBhQ2OlyLd9Iy1kNxG7F84SWga1oHKp39HiNWdh2a0vEEskikC371U DJ3vK+k8XEmMH4ocl1Xn9m9s/JCfBuUcQ7g4sFgqg/gQKvG9mfBeMx9/DgjM6/nJWG48LzW9uyq wsmidRze6ogVdDbgSr5W6MkfQWGqU6moNE4QDmLsY96IIOpP8PLeixlKiE+8vfveLrlMEu8VVYW L3j1LKnAol5/9IuN5zQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_03,2026-06-15_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 clxscore=1015 spamscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150155 On 6/10/26 4:09 PM, Stephan Gerhold wrote: > On Wed, Jun 10, 2026 at 03:50:11PM +0200, Konrad Dybcio wrote: >> On 6/9/26 4:14 PM, Stephan Gerhold wrote: >>> From: Stephan Gerhold >>> >>> This clock does not seem to exist on MDM9607. Reading/writing the registers >>> always results in 0 or crashes. The math in the frequency table is also >>> broken. GPLL2 on MDM9607 runs at 480 MHz, so: >>> >>> - F(155000000, P_GPLL2, 6, 0, 0), // 480 MHz/6 = 80 MHz, not 155 MHz >>> - F(310000000, P_GPLL2, 3, 0, 0), // 480 MHz/3 = 160 MHz, not 310 MHz >>> >>> Presumably, this definition was mistakenly copied as-is from gcc-msm8916 >>> (which uses 930 MHz for GPLL2). There are no branch consumers of this root >>> clock inside gcc-mdm9607 (notably, gcc_apss_tcu_clk has bimc_ddr_clk_src as >>> parent instead of this clock), so we can just drop it. >>> >>> Cc: stable@vger.kernel.org >>> Fixes: 48b7253264ea ("clk: qcom: Add MDM9607 GCC driver") >>> Signed-off-by: Stephan Gerhold >>> --- >> >> It does, CMD_RCGR @ 0x37000 >> >> Interestingly, there's also an SMMU instance.. although downstream doesn't >> seem bothered with it >> > > Thanks for checking, but that still doesn't give us enough to work with > it. In particular: > > - What are the frequency tables? Which parents exist with which IDs? > - What is the hid_width? > - Where do we hook it up to some children? > > The way it is right now it's definitely wrong. I don't think we'll need > it so removing it like this patch is probably the easiest thing to do... > > Thanks, > Stephan > > PS: This platform has the weird TZ-managed SMMU (like MSM8916), so there > isn't much you can do with it from Linux. Unless you are running TF-A, > then you can describe it as "arm,mmu-500" and use it for everything > pretty much exactly like you would normally expect. But you still don't > need to do anything with this clock. Alright then, let's just get rid of it Reviewed-by: Konrad Dybcio Konrad