Re: [PATCH 1/3] acpi: video: trivial costmetic cleanups

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Friday, August 02, 2013 12:52:18 PM Felipe Contreras wrote:
> On Fri, Aug 2, 2013 at 9:05 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > On Thursday, August 01, 2013 11:15:38 PM Felipe Contreras wrote:
> >> On Thu, Aug 1, 2013 at 8:50 PM, Aaron Lu <aaron.lwe@gmail.com> wrote:
> >> > On 08/02/2013 07:43 AM, Felipe Contreras wrote:
> >> >> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> >> >
> >> > Please add change log explaining what you have changed.
> >> > It seems that the patch modify comment style only, some add a space and
> >> > some change spaces to tab, is it the case?
> >>
> >> The commit message already explains what the change is; trivial
> >> cosmetic cleanups. Cosmetic means it's completely superficial.
> >
> > And I have a rule not to apply patches without changelogs.  So either I'll
> > need to write it for you, or can you add one pretty please?
> 
> The commit message is right there. Maybe Jiri can apply it then, if
> not, then stay happy with your untidy code.

First of all, I didn't say I wouldn't apply the patch, did I?

Second, I asked you *nicely* to add a changelog so that I don't need to write
it for you.

I don't know what made it difficult to understand.

Anyway, I ask everyone to write changelogs and nobody has had any problems with
that so far.  I don't see why I should avoid asking you to follow the rules
that everybody else is asked to follow.  If those rules are too difficult for
you to follow, I'm sorry.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.