mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nish Aravamudan <nish.aravamudan@gmail.com>
To: Harald Welte <laforge@gnumonks.org>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH 1/2] New Omnikey Cardman 4040 driver
Date: Tue, 13 Sep 2005 09:02:22 -0700	[thread overview]
Message-ID: <29495f1d050913090219cc44fa@mail.gmail.com> (raw)
In-Reply-To: <20050913155116.GY29695@sunbeam.de.gnumonks.org>

On 9/13/05, Harald Welte <laforge@gnumonks.org> wrote:
> Hi!
> 
> I've now incorporated all requested/suggested changes. Please apply the
> following patch to the mainline tree, thanks!

<snip>

> diff --git a/drivers/char/pcmcia/cm4040_cs.c b/drivers/char/pcmcia/cm4040_cs.c

<snip>

> +static ssize_t cm4040_read(struct file *filp, char __user *buf,
> +                       size_t count, loff_t *ppos)
> +{

<snip>

> +       schedule_timeout(1*HZ);

This needs a state set, or it will return immediately. Use either
schedule_timeout_interruptible() or schedule_timeout_uninterruptible()
(merged in 2.6.14-rc1). Otherwise the patches look good.

Thanks,
Nish

  reply	other threads:[~2005-09-13 16:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-13 15:51 Harald Welte
2005-09-13 16:02 ` Nish Aravamudan [this message]
2005-09-13 16:39   ` Harald Welte
2005-09-14  9:19     ` Andrew Morton
2005-09-18 21:23       ` Harald Welte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29495f1d050913090219cc44fa@mail.gmail.com \
    --to=nish.aravamudan@gmail.com \
    --cc=laforge@gnumonks.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®