From: Nish Aravamudan <nish.aravamudan@gmail.com>
To: 7eggert@gmx.de
Cc: "Daniel Marjamäki" <daniel.marjamaki@comhem.se>,
linux-kernel@vger.kernel.org
Subject: Re: I made a patch and would like feedback/testers (drivers/cdrom/aztcd.c)
Date: Sun, 20 Nov 2005 13:07:32 -0800 [thread overview]
Message-ID: <29495f1d0511201307n29fd2095md0d9543d5aef9968@mail.gmail.com> (raw)
In-Reply-To: <E1EdwGs-0000qv-NL@be1.lrz>
On 11/20/05, Bodo Eggert <harvested.in.lkml@posting.7eggert.dyndns.org> wrote:
> Daniel Marjamäki <daniel.marjamaki@comhem.se> wrote:
>
> > - aztTimeOutCount = 0;
> > + aztTimeOut = jiffies + 2;
>
> Different timeout based on HZ seems wrong.
True; I'm trying to think of a good way to emulate 8000000 iterations
of loop, though. Really, this is not terrible to use 2 jiffies of
offset, as we try to sleep 1 jiffy each time. As long as we don't get
a signal *right* away, we'll sleep probably for 2 loops. Not sure,
though, may be useful to see what happens in practice and then debug
further for the right value.
May also want to use time_after_eq() not time_after().
Thanks,
Nish
next prev parent reply other threads:[~2005-11-20 21:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5aZsv-3CJ-17@gated-at.bofh.it>
2005-11-20 20:58 ` Bodo Eggert
2005-11-20 21:07 ` Nish Aravamudan [this message]
2005-11-21 8:09 ` Daniel Marjamäki
2005-11-21 8:19 ` Con Kolivas
2005-11-21 8:42 ` Daniel Marjamäki
2005-11-21 9:11 ` Con Kolivas
2005-11-21 10:47 ` Nick Piggin
2005-11-21 15:08 ` Nish Aravamudan
2005-11-21 16:33 ` Bodo Eggert
2005-11-20 15:29 Daniel Marjamäki
2005-11-20 15:38 ` Arjan van de Ven
2005-11-20 17:15 ` Thomas Gleixner
2005-11-20 21:04 ` Nish Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29495f1d0511201307n29fd2095md0d9543d5aef9968@mail.gmail.com \
--to=nish.aravamudan@gmail.com \
--cc=7eggert@gmx.de \
--cc=daniel.marjamaki@comhem.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®