From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1759173AbXFRQwR@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759173AbXFRQwR (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Jun 2007 12:52:17 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752866AbXFRQwB
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 18 Jun 2007 12:52:01 -0400
Received: from ug-out-1314.google.com ([66.249.92.174]:42382 "EHLO
	ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752769AbXFRQwA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Jun 2007 12:52:00 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=QsnZ9+fmHEKIP1bQORdw3hTYXCIB/UFy4Yg9mbVXavtWAOjdqvicou5X1aBXmD6Az49MWWmt/vgpJNpGSjf9s2MOwDAo33Ip2jvgNPn9eWj3Mjhxh+J7AM7+ljWDkxYPFdsHceFLDBlSctHuAxdYEGPcxuzq1UUku9hAckvreRA=
Message-ID: <29495f1d0706180951r2b7d0fe1gdcc0158011baf637@mail.gmail.com>
Date: Mon, 18 Jun 2007 09:51:59 -0700
From: "Nish Aravamudan" <nish.aravamudan@gmail.com>
To: "Jason Baron" <jbaron@redhat.com>
Subject: Re: [PATCH] madvise_need_mmap_write() usage
Cc: "Christoph Hellwig" <hch@infradead.org>, linux-kernel@vger.kernel.org,
       linux-mm@kvack.org, nickpiggin@yahoo.com.au,
       "Rik van Riel" <riel@redhat.com>
In-Reply-To: <Pine.LNX.4.64.0706181132020.23021@dhcp83-20.boston.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <Pine.LNX.4.64.0706151118150.11498@dhcp83-20.boston.redhat.com>
	 <20070616194130.GA6681@infradead.org>
	 <Pine.LNX.4.64.0706181132020.23021@dhcp83-20.boston.redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/18/07, Jason Baron <jbaron@redhat.com> wrote:
>
> On Sat, 16 Jun 2007, Christoph Hellwig wrote:
>
> > On Fri, Jun 15, 2007 at 11:20:31AM -0400, Jason Baron wrote:
> > > hi,
> > >
> > > i was just looking at the new madvise_need_mmap_write() call...can we
> > > avoid an extra case statement and function call as follows?
> >
> > Sounds like a good idea, but please move the assignment out of the
> > conditional.
> >
>
> ok, here's an updated version:

You should always append the full patch, both the diff and the
rationale, I think. Even though it's quoted above, might make less
work for Andrew to pull in.

Thanks,
Nish