From: "Nish Aravamudan" <nish.aravamudan@gmail.com>
To: jschopp <jschopp@austin.ibm.com>
Cc: "Dave Jones" <davej@redhat.com>,
apw@shadowen.org, rdunlap@xenotime.net,
"Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: Make checkpatch warn about pointless casting of kalloc returns.
Date: Wed, 8 Aug 2007 11:40:31 -0700 [thread overview]
Message-ID: <29495f1d0708081140s5b8c2cc8xcf929f1aad9c0530@mail.gmail.com> (raw)
In-Reply-To: <46BA0B28.4090404@austin.ibm.com>
On 8/8/07, jschopp <jschopp@austin.ibm.com> wrote:
> > > > + WARN("No need to cast return value.\n");
> > >
> > > Could the warning be more descriptive? This describes what, but it should also describe
> > > why; after all if somebody made this error they may not know they why.
> >
> > I'm open to suggestions..
>
> How about
>
> WARN("No need to cast return value, it is unnecessary and can hide real bugs. See
> http://c-faq.com/malloc/mallocnocast.html for more details\n");
That's a long line. Can it be split into two? Otherwise seems sane.
Thanks,
Nish
next prev parent reply other threads:[~2007-08-08 18:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 2:43 Dave Jones
2007-08-08 17:05 ` jschopp
2007-08-08 18:00 ` Dave Jones
2007-08-08 18:10 ` Cal Peake
2007-08-08 18:27 ` jschopp
2007-08-08 18:40 ` Nish Aravamudan [this message]
2007-08-13 10:24 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29495f1d0708081140s5b8c2cc8xcf929f1aad9c0530@mail.gmail.com \
--to=nish.aravamudan@gmail.com \
--cc=apw@shadowen.org \
--cc=davej@redhat.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®