From: "Nish Aravamudan" <nish.aravamudan@gmail.com>
To: "Adrian Bunk" <bunk@kernel.org>
Cc: wli@holomorphy.com, lethal@linux-sh.org,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: HugeTLB vs. SH3 cpu
Date: Tue, 1 Apr 2008 16:26:14 -0700 [thread overview]
Message-ID: <29495f1d0804011626n2399d69aj7566df7f78953458@mail.gmail.com> (raw)
In-Reply-To: <20080401225809.GC32269@cs181133002.pp.htv.fi>
On 4/1/08, Adrian Bunk <bunk@kernel.org> wrote:
> fs/Kconfig says:
>
> config HUGETLBFS
> bool "HugeTLB file system support"
> depends on X86 || IA64 || PPC64 || SPARC64 || (SUPERH && MMU) || BROKEN
>
>
> arch/sh/mm/Kconfig says:
>
> choice
> prompt "HugeTLB page size"
> depends on HUGETLB_PAGE && (CPU_SH4 || CPU_SH5) && MMU
So the problem is that SH3 is allowed to enable
HUGETLB_PAGE/HUGETLBFS, but only SH4/5 define the HPAGE_SHIFT macro,
due to some #ifdeffery on the hugepage size. So either the choice
needs to be extended to include CPU_SH3 (which builds here, when
changed) or the HUGETLBFS conditional needs to depend more
specifically on SH4/5 and not just SUPERH. I think the arch maintainer
has to make that call, as I don't know the hardware to say if SH3
actually supports multiple hugepage sizes.
Thanks,
Nish
next prev parent reply other threads:[~2008-04-01 23:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-01 22:58 Adrian Bunk
2008-04-01 23:26 ` Nish Aravamudan [this message]
2008-04-02 8:04 ` Paul Mundt
2008-04-02 10:15 ` Mel Gorman
2008-04-03 5:52 ` Paul Mundt
2008-04-02 22:55 ` Nishanth Aravamudan
2008-04-03 0:06 ` Dave Hansen
2008-04-03 5:48 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29495f1d0804011626n2399d69aj7566df7f78953458@mail.gmail.com \
--to=nish.aravamudan@gmail.com \
--cc=bunk@kernel.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®