From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B983CC433B4 for ; Sat, 8 May 2021 09:41:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 980CA6101D for ; Sat, 8 May 2021 09:41:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230349AbhEHJmy (ORCPT ); Sat, 8 May 2021 05:42:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32237 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229870AbhEHJmx (ORCPT ); Sat, 8 May 2021 05:42:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620466911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e8g0FbMtPR9vOJqczBJQph07+IiVAO0G06d1hPFLBp4=; b=aWjbNej+VqLqgzzosPNbISMsucXibFXK7gDzuWPEc0t4TojY5LRJ2bwBpzW11zZ7q73AGn CIwnTN2ziT2kTq1qZtEUgBUZK4uELkg7qmPs9+8RxUpSS7LIKSzr5CFdvgrlkeNedO+Fum u4KumnA3rUJNgWNactnb68KMUmsHvHg= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-568-t5vemS4_O7GqLa2RwdjNMA-1; Sat, 08 May 2021 05:41:48 -0400 X-MC-Unique: t5vemS4_O7GqLa2RwdjNMA-1 Received: by mail-ed1-f71.google.com with SMTP id u30-20020a50a41e0000b0290385504d6e4eso5879713edb.7 for ; Sat, 08 May 2021 02:41:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=e8g0FbMtPR9vOJqczBJQph07+IiVAO0G06d1hPFLBp4=; b=itE1zZeO17ncVCXEJhi4IRHWT48T7D6umd0O+EqL9F439pUP42F9sqAKeoX7Ow3a9v nyM5zujxzIyiJK2BWz7/UQ5W/cJMqJ76QEoUI9Vl/GXUU/mfYnN+B6RSBeEpjP2z7DKa FK0sseDOB+H+FH2cfkfQSQU/jvuknkLVZY7PaTnVivovCp9U3ba4CgWdiRD5rOrsKjYL z57Hc+oxbMTtsHoXOQlgjidZa4tNnGfijwpP2z/5EG/aAIfsO3XrDSG1kvK1l31/VfjQ M2htcFu1wyqhNsfCnQWXr6gQ6/7L6jIbS1qVmnizpXOVhoDeTlZM5g4Rn4JtmI2ne0ki Zjlw== X-Gm-Message-State: AOAM531XQHu6r5ACQIff+mVaU9MeMKl8F2rik3tKZXOdfnuNe07NLbvJ f9RPoSuP4HE6AI9Do70CJSrrG7itX5Prw2FBbp4RTA890wkR/26QSIweXD5ZsrJCtLKCyKOQn9u SpnpPCn37lHqrt+4l0RB0Rq5T X-Received: by 2002:a17:906:80d6:: with SMTP id a22mr14495186ejx.159.1620466907125; Sat, 08 May 2021 02:41:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxri80XuBnxGDuVafu5UlMWlY6ndqQ/BrRSzL1WJ1RXqM0/pLeNgvGYwaJJ07V1m729A99mKw== X-Received: by 2002:a17:906:80d6:: with SMTP id a22mr14495176ejx.159.1620466906968; Sat, 08 May 2021 02:41:46 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id q10sm6026768eds.36.2021.05.08.02.41.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 May 2021 02:41:46 -0700 (PDT) Subject: Re: [PATCH v2] iio: bme680_i2c: Remove ACPI support To: Andy Shevchenko , Guenter Roeck Cc: Jonathan Cameron , Jonathan Cameron , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , kernel test robot References: <20210506034332.752263-1-linux@roeck-us.net> <20210507103154.00006763@Huawei.com> <20210508030936.GA3879276@roeck-us.net> From: Hans de Goede Message-ID: <294dacb7-aef3-ede0-e46d-5c8fd91e9c17@redhat.com> Date: Sat, 8 May 2021 11:41:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 5/8/21 9:48 AM, Andy Shevchenko wrote: > > > On Saturday, May 8, 2021, Guenter Roeck > wrote: > > On Fri, May 07, 2021 at 10:31:54AM +0100, Jonathan Cameron wrote: > > On Wed,  5 May 2021 20:43:32 -0700 > > Guenter Roeck > wrote: > > > > > With CONFIG_ACPI=n and -Werror, 0-day reports: > > > > > > drivers/iio/chemical/bme680_i2c.c:46:36: error: > > >     'bme680_acpi_match' defined but not used > > > > > > Apparently BME0680 is not a valid ACPI ID. Remove it and with it > > > ACPI support from the bme680_i2c driver. > > > > > > Reported-by: kernel test robot > > > > Cc: Andy Shevchenko > > > > Cc: Hans de Goede > > > > Signed-off-by: Guenter Roeck > > > > > A note for these is that I'll change the patch titles when applying. > > We aren't removing ACPI support from the drivers, we are simply > > removing the ACPI ID table entries.  For most of these PRP0001 magic > > will work just fine with the OF table.  That's probably the > > right way for small companies etc to use these in products without > > having to jump through the hoops of getting an ACPI ID. > > > > Below is what Coccinelle tells me about ACPI IDs in drivers/iio. > The script (tries) to do a prefix match of all ACPI IDs it finds against > the PNP and ACPI ID databases from https://uefi.org/PNP_ACPI_Registry . > > Andy, Hans, does that look about right ? > > > > The result looks nice for the first step! >   > > > Next question is what to do with the mismatches and with false > negatives such as: > > drivers/iio/accel/stk8312.c >   STK8312: match (prefix) against STK (SANTAK CORP.) > drivers/iio/light/isl29018.c >   ISL29018: match (prefix) against ISL (Isolation Systems) >   ISL29023: match (prefix) against ISL (Isolation Systems) >   ISL29035: match (prefix) against ISL (Isolation Systems) > drivers/iio/gyro/bmg160_i2c.c > > >   > >   BMI055B: match (prefix) against BMI (Benson Medical Instruments Company) >   BMI088B: match (prefix) against BMI (Benson Medical Instruments Company) > > > These I think the real ones from the existing devices. No that is wrong, these are Bosch sensors, so the BOSC0200 entry for the companion accelerometer is the only entry using the official company prefix. At least "BMA" ("BMA250E") and "BSG" ("BSG1160", "BSG2150") are also know to be used as prefixes for ACPI HIDs which are in active use for Bosch sensors :| And Benson Medical Instruments Company has nothing to do with these sensors :| Regards, Hans