From: Mario Limonciello <mario.limonciello@amd.com>
To: "Mark Brown" <broonie@kernel.org>,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
sound-open-firmware@alsa-project.org,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: SOF: amd: Load alternatively signed firmware with an "_l" suffix
Date: Thu, 5 Nov 2026 08:16:43 -0600 [thread overview]
Message-ID: <29502d1f-6358-4d9d-9898-7295b3cc203c@amd.com> (raw)
In-Reply-To: <75156710-5ef8-4575-8f78-d65b9d752200@sirena.org.uk>
On 11/5/26 08:07, Mark Brown wrote:
> On Thu, Nov 05, 2026 at 04:03:32PM +0200, Péter Ujfalusi wrote:
>> On 04/11/2026 23:53, Mario Limonciello wrote:
>
>>> + ret = amd_smn_read(0, MP0_C2PMSG_63_REG, &val);
>>> + if (ret) {
>>> + dev_err(sdev->dev, "failed to read PSP firmware signing type: %d\n", ret);
>
>>> + /* all ones means the register isn't accessible */
>>> + if (val == 0xffffffff)
>>> + return -EIO;
>
>> this would also merit an error print?
>
> amd_smn_read() will convert this to -ENODEV anyway so that won't be
> reached.
Oh yeah; that's dead code then, thanks. I'll respin to drop it.
prev parent reply other threads:[~2026-11-05 14:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 21:53 Mario Limonciello
2026-11-05 14:03 ` Péter Ujfalusi
2026-11-05 14:07 ` Mark Brown
2026-11-05 14:16 ` Mario Limonciello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29502d1f-6358-4d9d-9898-7295b3cc203c@amd.com \
--to=mario.limonciello@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®