From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Darren Hart <dvhart@infradead.org>
Cc: Azael Avalos <coproscefalo@gmail.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2 3/3] toshiba_acpi: Change HCI/SCI functions return code type
Date: Wed, 01 Oct 2014 03:58:34 +0200 [thread overview]
Message-ID: <2951962.6yqkWfcajp@vostro.rjw.lan> (raw)
In-Reply-To: <20140930205814.GB47302@vmdeb7>
On Tuesday, September 30, 2014 01:58:14 PM Darren Hart wrote:
> On Mon, Sep 29, 2014 at 08:40:09PM -0600, Azael Avalos wrote:
> > Currently the HCI/SCI read/write functions are returning
> > the status of the ACPI call and also assigning the
> > returned value of the HCI/SCI function, however, only
> > the HCI/SCI status is being checked.
> >
> > This patch changes such functions, returning the value
> > of the HCI/SCI function instead of the ACPI call status,
> > eliminating one parameter, and returning something
> > useful that indeed is being checked.
> >
> > Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
>
> Cc linux-acpi
>
> Rafael,
>
> This follows a couple patches renaming interfaces and error codes. While
> there is some information to be had in checking for ACPI specific errors, I
> don't think it's significant to warrant asking Azael to go the other way and
> check for them specifically and add errorcodes to the interface rather than
> cleanup the functionality as it stands today and simplifiy the code as he does
> here.
>
> Any objection?
Nope.
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2014-10-01 1:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 2:40 [PATCH v2 0/3] Return codes cleanup Azael Avalos
2014-09-30 2:40 ` [PATCH v2 1/3] toshiba_acpi: Rename hci_raw to tci_raw Azael Avalos
2014-09-30 2:40 ` [PATCH v2 2/3] toshiba_acpi: Unify return codes prefix from HCI/SCI to TOS Azael Avalos
2014-09-30 2:40 ` [PATCH v2 3/3] toshiba_acpi: Change HCI/SCI functions return code type Azael Avalos
2014-09-30 20:58 ` Darren Hart
2014-10-01 1:58 ` Rafael J. Wysocki [this message]
2014-09-30 20:54 ` [PATCH v2 0/3] Return codes cleanup Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2951962.6yqkWfcajp@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=coproscefalo@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®