From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752874AbbJOS5m (ORCPT ); Thu, 15 Oct 2015 14:57:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40993 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbbJOS5k (ORCPT ); Thu, 15 Oct 2015 14:57:40 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1444926178-28856-1-git-send-email-wuninsu@gmail.com> References: <1444926178-28856-1-git-send-email-wuninsu@gmail.com> To: Insu Yun Cc: dhowells@redhat.com, james.l.morris@oracle.com, serge@hallyn.com, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu Subject: Re: [PATCH] keys: correctly check failed allocation for kmemdup MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <29543.1444935453.1@warthog.procyon.org.uk> Date: Thu, 15 Oct 2015 19:57:33 +0100 Message-ID: <29544.1444935453@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Insu Yun wrote: > kmemdup return value is saved in 'key->index_key.description', not > 'key->descrption' and kmemdup can be failed in memory pressure. > Therefore, key->index_key.description should be checked. The fields are unioned. It makes no difference. David