From: Tengfei Fan <quic_tengfan@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <andersson@kernel.org>,
<agross@kernel.org>, <linus.walleij@linaro.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel@quicinc.com>
Subject: Re: [PATCH 1/2] pinctrl: qcom: Convert to platform remove callback returning void
Date: Thu, 30 Nov 2023 09:11:32 +0800 [thread overview]
Message-ID: <2958722e-94b9-46d1-9f0c-3fc241a3e633@quicinc.com> (raw)
In-Reply-To: <2d6c7d2e-c8f5-4e7f-901a-8ca208d7b442@linaro.org>
在 11/29/2023 9:21 PM, Konrad Dybcio 写道:
> On 29.11.2023 11:04, Tengfei Fan wrote:
>> Use .remove_new() instead of .remove() for converting to plarform remove
> s/plarform/platform
>
>> callback returning void.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
> The commit title should include the platform name, i.e.
> pinctrl: qcom: sm4450: xxx
>
> The change itself looks good
>
> Konrad
Thanks Konrad review this patch, I will update patch as your comments.
--
Thx and BRs,
Tengfei Fan
next prev parent reply other threads:[~2023-11-30 1:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 10:04 [PATCH 0/2] pinctrl: qcom: fix some sm4450 pinctrl issue Tengfei Fan
2023-11-29 10:04 ` [PATCH 1/2] pinctrl: qcom: Convert to platform remove callback returning void Tengfei Fan
2023-11-29 13:21 ` Konrad Dybcio
2023-11-30 1:11 ` Tengfei Fan [this message]
2023-11-29 10:04 ` [PATCH 2/2] pinctrl: qcom: correct incorrect address offset Tengfei Fan
2023-11-29 13:32 ` Konrad Dybcio
2023-11-30 1:12 ` Tengfei Fan
2023-11-30 1:13 ` Tengfei Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2958722e-94b9-46d1-9f0c-3fc241a3e633@quicinc.com \
--to=quic_tengfan@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®