From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: like@awinic.com, lgirdwood@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
liweilei@awinic.com, liangdong@awinic.com, yijiangtao@awinic.com
Subject: Re: [PATCH V1 1/1] regulator: Add awinic,aw3750x.yaml
Date: Wed, 5 Jul 2023 19:20:04 +0200 [thread overview]
Message-ID: <295e4cb9-0fa1-8370-72da-ade8123c90a5@linaro.org> (raw)
In-Reply-To: <17ad855b-3a3b-4dba-9a64-a1a683b3b905@sirena.org.uk>
On 05/07/2023 13:52, Mark Brown wrote:
> On Wed, Jul 05, 2023 at 11:20:16AM +0200, Krzysztof Kozlowski wrote:
>> On 05/07/2023 10:19, like@awinic.com wrote:
>>> From: Ke Li <like@awinic.com>
>
>>> +properties:
>>> + compatible:
>>> + const: awinic,aw3750x_led
>
>> I don't understand why there is _led suffix. Isn't this regulator? Can
>> it be anything else?
>
> Boost regulators are almost always used to drive LEDs for things like
> backlights.
Let me be a bit more precise - if this device can have multiple
functions, then the compatible usually has some suffixes (although no
underscores). If this device has only one feature - regardless whether
for backlight or for anything else - the compatible has only model.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-05 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 8:19 [PATH V2 0/2] regulator: aw3750x: AW3750X regulator driver like
2023-07-05 8:19 ` [PATCH V1 1/1] regulator: Add awinic,aw3750x.yaml like
2023-07-05 9:20 ` Krzysztof Kozlowski
2023-07-05 11:52 ` Mark Brown
2023-07-05 17:20 ` Krzysztof Kozlowski [this message]
2023-07-05 9:36 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=295e4cb9-0fa1-8370-72da-ade8123c90a5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=liangdong@awinic.com \
--cc=like@awinic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liweilei@awinic.com \
--cc=robh+dt@kernel.org \
--cc=yijiangtao@awinic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®