From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752447AbdBJLXG (ORCPT ); Fri, 10 Feb 2017 06:23:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37056 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751956AbdBJLXE (ORCPT ); Fri, 10 Feb 2017 06:23:04 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1479584622-7570-1-git-send-email-dave@stgolabs.net> References: <1479584622-7570-1-git-send-email-dave@stgolabs.net> To: Davidlohr Bueso Cc: dhowells@redhat.com, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH] security: use READ_ONCE instead of deprecated ACCESS_ONCE MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <29605.1486725644.1@warthog.procyon.org.uk> Date: Fri, 10 Feb 2017 11:20:44 +0000 Message-ID: <29606.1486725644@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 10 Feb 2017 11:20:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Davidlohr Bueso wrote: > With the new standardized functions, we can replace all ACCESS_ONCE() > calls across relevant security/keyrings/. > > ACCESS_ONCE() does not work reliably on non-scalar types. For example > gcc 4.6 and 4.7 might remove the volatile tag for such accesses during > the SRA (scalar replacement of aggregates) step: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 > > Update the new calls regardless of if it is a scalar type, this is > cleaner than having three alternatives. > > Signed-off-by: Davidlohr Bueso Applied.