From: Bart Van Assche <bvanassche@acm.org>
To: John Garry <john.garry@huawei.com>,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com
Cc: linuxarm@huawei.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2] scsi: sd: Make protection lookup tables static and relocate functions
Date: Tue, 8 Jan 2019 18:42:35 -0800 [thread overview]
Message-ID: <29616f54-5c48-96da-e3b4-c211fd28d82e@acm.org> (raw)
In-Reply-To: <1546960492-218420-1-git-send-email-john.garry@huawei.com>
On 1/8/19 7:14 AM, John Garry wrote:
> Currently the protection lookup tables in sd_prot_flag_mask() and
> sd_prot_op() are declared as non-static. As such, they will be rebuilt
> for each respective function call.
>
> Optimise by making them static.
>
> This saves ~100B object code for sd.c:
>
> Before:
> text data bss dec hex filename
> 25403 1024 16 26443 674b drivers/scsi/sd.o
>
> After:
> text data bss dec hex filename
> 25299 1024 16 26339 66e3 drivers/scsi/sd.o
>
> In addition, since those same functions are declared in sd.h, but each are
> only referenced in sd.c, relocate them to that same c file.
>
> The inline specifier is dropped also, since gcc should be able to make the
> decision to inline.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2019-01-09 2:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 15:14 John Garry
2019-01-09 2:42 ` Bart Van Assche [this message]
2019-01-09 3:30 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29616f54-5c48-96da-e3b4-c211fd28d82e@acm.org \
--to=bvanassche@acm.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome