From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752513AbbKYUKA (ORCPT ); Wed, 25 Nov 2015 15:10:00 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:53660 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549AbbKYUJ6 (ORCPT ); Wed, 25 Nov 2015 15:09:58 -0500 From: Arnd Bergmann To: David Daney Cc: linux-arm-kernel@lists.infradead.org, Bjorn Helgaas , David Daney , David Daney , Marc Zyngier , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, "Sean O. Stalley" , linux-pci@vger.kernel.org, Bjorn Helgaas Subject: Re: [RFC PATCH] PCI/pci-host-generic: Add support for Cavium Thunder fixed BARs. Date: Wed, 25 Nov 2015 21:09:15 +0100 Message-ID: <2971730.8fz1SdakMA@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <5656149D.50704@caviumnetworks.com> References: <1443488184-12633-1-git-send-email-ddaney.cavm@gmail.com> <2789794.TBZL2yW2b6@wuerfel> <5656149D.50704@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:DvlBP+7sFZJmk3j4h1y3lZxtw30Cl8TlT93JHhN5QkueYmGryyq K/lhIGrMxtBwOPkF+puYXUbZJ4zwybQU+QeV/0qfOGHKRQLoQZ9CIkBfFlhDngkxJZttHx/ MwBnMutASFzUr/erCC/kRk28wHSlWHdCIFge0N6AqVXEVbZk5vkvoWeFEsh6S+jGyv3Q7g1 SRLiucGq2pz0xaqyfJP6g== X-UI-Out-Filterresults: notjunk:1;V01:K0:RUdw4DGFbCc=:7gP/XUlGdWxy2kRS8h3b6u Bc9lxJMOU0Q7CRcnWRvLDsdv2Sorfs7otJ8nVgG6rtOvVyEclxiZNYaevuiypSFZGl12KEusy TlwBhG/Pl5XmGT8n13nuhl7zEBBQWne+K2NI6dQ0Tvc1Vbz/OuvJPHeltxuVpmCNSYIGM2l9e dk/+HDcDi/GHNDRq0MGDNJ8PLiGGhwFPV+vdG5WswHu03F48a+uti7/EaXRtS1IrGjf/IAxLG G/k7IgcKP0zJ7zWYK0uR3CpI/mZKE8O3UGaN/kvhdKKMzEK66/PnxhdWpKdxZkw64ikvWuZ7T SsW6j4hCPcuQ5GLSh05H61Ql1DrxQBRa5N+FzSG+ZTt0vqZxsYHDEmTta/7abTKG2jzgX5oKK AWvm9rqk3v3C3xeeRnGWwwhLEY8aEtGlu6pMOn/yvIxhx6jkx4OaURmI4cUypltpwLHNOco5A 0UEGTcElTVR96RhniMzIhnel7IKO6G0/dxJYGWM/Qx6m5RpHOEn8chycgpz2tBrCTmmBYS8nH R+NSSpEUj7ClAjIYXSx4a+D4B/OoYjI9dX/1kXYXBSkrnY4LNIRus9UZiJzj1KvKd7r52a/1Z PgTJqgn80OjzfM1z6k/akjME5y+qwD2diPenOAqJR7ZT21LHhHMYGGUOk7yi6TOY+Dk3zdQ8W i+UVysTkQaW0IkebNB+9sCBbjgy1uijf49unFuLnZF5PwJs7nNnk/1s8BvxqQMJ/TW6yS/ze/ 9p2jHlFN84KX8uvb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 25 November 2015 12:05:49 David Daney wrote: > > Somebody should make a decision about this point. > > Here is what happens: > > 1) A driver for non-generic PCI host bridge is submitted. > > 2) Comments are received stating that it is just another PCI host > bridge and please use pci-host-generic instead. > > 3) Patches to pci-host-generic are submitted. > > 4) Comments are received stating that pci-host-generic is for generic > things only, and please create a device specific driver. > > 5) goto 1 I'm pretty sure the comments were along the lines of 1) a driver was submitted stating that it was for an SBSA-compliant platform 2) The reply was that you don't need a driver for that and just use the generic driver, as that is the point of SBSA 3) it turns out the hardware is nonstandard after all and so it needs its own driver. > > It's easy enough to split out the common parts if we want to reuse > > some of this, or to move them into drivers/pci/*.c for others to > > reuse too. > > > > If we do that, do you want "pci-host-cam-generic" and > "pci-host-ecam-generic" split out too? > > They are two completely different things crammed into the single > pci-host-generic driver source file. Or is there some set of config > access methods that are sufficiently generic that they can stay? Those two are part of the PCI standard, they are obviously generic because any mmconfig compliant host bridge will work with one or the other. Arnd