From: James Clark <james.clark@linaro.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>,
linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Andi Kleen <ak@linux.intel.com>,
"open list:PERFORMANCE EVENTS SUBSYSTEM"
<linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH] perf print_insn: Include sys/types.h for ssize_t
Date: Mon, 26 Oct 2026 18:27:25 +0000 [thread overview]
Message-ID: <297198e4-3179-4de6-b5c4-ede4faa92ebf@linaro.org> (raw)
In-Reply-To: <20261026174535.3157580-1-florian.fainelli@broadcom.com>
On 26/10/2026 17:45, Florian Fainelli wrote:
> print_insn.h declares fprintf_insn_asm() with an ssize_t return type but
> does not include the header defining that type. This causes builds where
> stdio.h does not provide ssize_t to fail when compiling util/print_insn.c:
>
> util/print_insn.h:21:1: error: unknown type name 'ssize_t'
>
> Include sys/types.h so the header provides its own dependency for ssize_t.
>
> Fixes: 218c200f677d ("perf script: Consolidate capstone print functions")
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
> tools/perf/util/print_insn.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/print_insn.h b/tools/perf/util/print_insn.h
> index cefa5c5f246e..3de9438af9cd 100644
> --- a/tools/perf/util/print_insn.h
> +++ b/tools/perf/util/print_insn.h
> @@ -4,6 +4,7 @@
>
> #include <stddef.h>
> #include <stdio.h>
> +#include <sys/types.h>
>
> #include <linux/types.h>
>
Reviewed-by: James Clark <james.clark@linaro.org>
next prev parent reply other threads:[~2026-10-26 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 17:45 Florian Fainelli
2026-10-26 18:27 ` James Clark [this message]
2026-10-27 20:39 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=297198e4-3179-4de6-b5c4-ede4faa92ebf@linaro.org \
--to=james.clark@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=florian.fainelli@broadcom.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®